ESQL: Track blocks #100025
Merged
ESQL: Track blocks #100025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates tracked `Block`s from topn and closes the blocks passed to it.
Fix some merge errors and re-enable some tests that work now that we have project working.
This properly handles allocation errors inside of topn by making
`Block.Builder` and `Vector.Builder` `Releasable`. The "new way" to deal
with block factories is like this:
```
try (var b = IntBlock.builder(3, blockFactory) {
b.append(1);
b.append(2);
b.append(3);
return b.build();
}
```
If anything goes wrong the block factory's `close` method will be called
by the `try` block and all of the circuit breaking that it reserves will
be released.
For this all to work well `Block.Builder`s have to be one-shot. In other
words, you can only call `.build` on them one time. That shifts the
accounting from the builder into the block. It is an error to call
`build` twice.
Get the tests working now that we're closing block all over the place.
Track memory in the builders and disable a failing test. We'll reenable later.
elasticsearchmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
|
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
nik9000
added
the
auto-merge-without-approval
|
These have been reviewed separately. This is open to get another round of CI. |
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
This tracks blocks from topn and a few other places. We're going to try and track blocks all the places.
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
This tracks blocks from topn and a few other places. We're going to try and track blocks all the places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks blocks from topn and a few other places. We're going to try and track blocks all the places.