-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] BreakingBytesRefBuilderTests testGrow failing #99649
Labels
:Analytics/ES|QL
AKA ESQL
blocker
Team:QL (Deprecated)
Meta label for query languages team
>test-failure
Triaged test failures from CI
Comments
iverase
added
:Analytics/ES|QL
AKA ESQL
>test-failure
Triaged test failures from CI
labels
Sep 19, 2023
elasticsearchmachine
added
the
Team:QL (Deprecated)
Meta label for query languages team
label
Sep 19, 2023
Pinging @elastic/es-ql (Team:QL) |
Pinging @elastic/elasticsearch-esql (:Query Languages/ES|QL) |
elasticsearchmachine
pushed a commit
that referenced
this issue
Sep 19, 2023
Flaky tests relates #99649
23 tasks
elasticsearchmachine
pushed a commit
that referenced
this issue
Oct 9, 2023
This commit fixes the intermittent failure of BreakingBytesRefBuilderTests. The issue is that the test uses the BreakingBytesRefBuilder's internal BytesRef array length to determine whether to expect a circuit breaker exception or not. Where it should use the builders length (not the capacity, a.k.a the internal BytesRef array length). The test failed intermittently about one in 10-20 runs before the change. The test passes successfully 100s of thousands of times with the fix. closes #99649
ChrisHegarty
added a commit
to ChrisHegarty/elasticsearch
that referenced
this issue
Oct 9, 2023
This commit fixes the intermittent failure of BreakingBytesRefBuilderTests. The issue is that the test uses the BreakingBytesRefBuilder's internal BytesRef array length to determine whether to expect a circuit breaker exception or not. Where it should use the builders length (not the capacity, a.k.a the internal BytesRef array length). The test failed intermittently about one in 10-20 runs before the change. The test passes successfully 100s of thousands of times with the fix. closes elastic#99649
elasticsearchmachine
pushed a commit
that referenced
this issue
Oct 9, 2023
This commit fixes the intermittent failure of BreakingBytesRefBuilderTests. The issue is that the test uses the BreakingBytesRefBuilder's internal BytesRef array length to determine whether to expect a circuit breaker exception or not. Where it should use the builders length (not the capacity, a.k.a the internal BytesRef array length). The test failed intermittently about one in 10-20 runs before the change. The test passes successfully 100s of thousands of times with the fix. closes #99649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
blocker
Team:QL (Deprecated)
Meta label for query languages team
>test-failure
Triaged test failures from CI
Build scan:
https://gradle-enterprise.elastic.co/s/473uj5rvxi2zu/tests/:x-pack:plugin:esql:compute:test/org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests/testGrow
Reproduction line:
Applicable branches:
main
Reproduces locally?:
Yes
Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.compute.operator.BreakingBytesRefBuilderTests&tests.test=testGrow
Failure excerpt:
The text was updated successfully, but these errors were encountered: