Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chunked rest encoding for Search APIs #95661

Open
3 of 4 tasks
romseygeek opened this issue Apr 28, 2023 · 4 comments
Open
3 of 4 tasks

Add Chunked rest encoding for Search APIs #95661

romseygeek opened this issue Apr 28, 2023 · 4 comments
Labels
>enhancement Meta :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@romseygeek
Copy link
Contributor

romseygeek commented Apr 28, 2023 •
edited
Loading

Description

This issue is to track adding chunked rest encoding to our various search APIs. Linked to #89838

We will also investigate adding further chunking to SearchResponse, which currently does not break up aggregations.
@romseygeek romseygeek added :Search/Search Search-related issues that do not fall into other categories Meta labels Apr 28, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Search Meta label for search team label Apr 28, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

This was referenced Apr 28, 2023
Merged
Open
Merged
@AkisPanagiotopoulos
Copy link

Hey, can i pick this up?

@romseygeek
Copy link
Contributor Author

Hi @AkisPanagiotopoulos, thanks for your interest! This is a fairly involved project so probably not the best to pick up for an external contributor yet. Once #94736 has been added the AsyncSearchResponse and SearchTemplateResponse changes will be fairly small and self-contained so it might be worth revisiting then? If you're looking for something to start off with, searching on the good first issue tag should give you some ideas.

romseygeek added a commit that referenced this issue May 2, 2023
@romseygeek
Don't throw exceptions during DocumentField serialization (#95673)
6365749 
As a prerequisite to making search responses use chunked REST serialization,
we need to ensure that no exceptions are thrown when toXContent gets called.
DocumentFields can currently throw exceptions if their contained values are not
serializable. This commit changes the serialization code here to replace
unserializable values with a placeholder value rather than failing the whole request.

Relates to #95661
@romseygeek romseygeek mentioned this issue Aug 11, 2023
Merged
romseygeek added a commit that referenced this issue Aug 16, 2023
@romseygeek
Make AsyncSearchResponse use Chunked ToXContent streaming (#98380)
6ef6186 
Relates to #95661
csoulios pushed a commit to csoulios/elasticsearch that referenced this issue Aug 18, 2023
@romseygeek @csoulios
Make AsyncSearchResponse use Chunked ToXContent streaming (elastic#98380
ba06782 
)

Relates to elastic#95661
@romseygeek romseygeek mentioned this issue Sep 4, 2023
Open
@javanna javanna added :Search Foundations/Search Catch all for Search Foundations and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement Meta :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javanna @romseygeek @elasticsearchmachine @AkisPanagiotopoulos