Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk health indicator doesn't take into account watermark.low/high.max_headroom #93155

Closed
fcofdez opened this issue Jan 23, 2023 · 0 comments · Fixed by #93157
Closed

Disk health indicator doesn't take into account watermark.low/high.max_headroom #93155

fcofdez opened this issue Jan 23, 2023 · 0 comments · Fixed by #93157
Labels

Comments

@fcofdez
Copy link
Contributor

fcofdez commented Jan 23, 2023

In #88639 we introduced a new setting that allows configuring a maximum headroom in disk watermarks that helps reducing the waste of disk space in large disks. The disk health indicator should take that new setting into account to avoid reporting issues when there's still room for new data in the cluster.

public ByteSizeValue getFreeBytesHighWatermark(ByteSizeValue total) {
return getFreeBytes(total, highWatermark, ByteSizeValue.MINUS_ONE);
}
public ByteSizeValue getFreeBytesFloodStageWatermark(ByteSizeValue total) {
return getFreeBytes(total, floodStageWatermark, ByteSizeValue.MINUS_ONE);
}

Those calls should take into account the available max headroom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant