Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractXContentFilteringTestCase#testDotsAndDoubleWildcardInExcludedFieldName is failing #92632

Closed
thecoop opened this issue Jan 3, 2023 · 3 comments · Fixed by #94195
Closed

AbstractXContentFilteringTestCase#testDotsAndDoubleWildcardInExcludedFieldName is failing #92632

thecoop opened this issue Jan 3, 2023 · 3 comments · Fixed by #94195
Labels
>bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.8.0

Comments

@thecoop
Copy link
Member

thecoop commented Jan 3, 2023

The AbstractXContentFilteringTestCase#testDotsAndDoubleWildcardInExcludedFieldName test (all subclasses) is failing. It is no longer failing due to invalid JSON (that was fixed by the upgrade to jackson 2.13.0), but it looks like it is failing to apply exclusions correctly.
@thecoop thecoop added >bug :Core/Infra/Core Core issues without another label v8.7.0 labels Jan 3, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 3, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@thecoop thecoop mentioned this issue Jan 3, 2023
Closed
thecoop added a commit that referenced this issue Jan 3, 2023
@thecoop
Update bug url for failing test (#92633)
4d37fee 
Remove references to fixed issue in jackson. Test is still failing for other reasons (#92632)
@thecoop
Copy link
Member Author

thecoop commented Jan 3, 2023 •
edited
Loading

**.X is failing to match {"A.B.X": ...}, but it is matching {"A": {"B": {"X": ...}}} for exclusions

@thecoop
Copy link
Member Author

thecoop commented Jan 3, 2023

The cause is that this line doesn't include matchFieldNamesWithDots, but the line below it (used for inclusion) does. This needs to be passed through a whole set of classes, so this is not a one-line fix.

@rjernst rjernst added v8.8.0 and removed v8.7.0 labels Feb 8, 2023
@thecoop thecoop mentioned this issue Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use double wildcards for filtered excludes properly thecoop/elasticsearch
3 participants
@rjernst @thecoop @elasticsearchmachine