Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsdb/05_dimension_and_metric_in_non_tsdb_index/nested dimensions #83915

Closed
nik9000 opened this issue Feb 14, 2022 · 2 comments · Fixed by #83920
Closed

tsdb/05_dimension_and_metric_in_non_tsdb_index/nested dimensions #83915

nik9000 opened this issue Feb 14, 2022 · 2 comments · Fixed by #83920
Assignees
@nik9000
Labels
:StorageEngine/TSDB You know, for Metrics >test-failure Triaged test failures from CI

Comments

@nik9000
Copy link
Member

nik9000 commented Feb 14, 2022 •
edited
Loading

CI Link

local

Repro line

./gradlew ':rest-api-spec:yamlRestTest' --tests "org.elasticsearch.test.rest.ClientYamlTestSuiteIT.test {yaml=tsdb/05_dimension_and_metric_in_non_tsdb_index/nested dimensions}" -Dtests.seed=CE43030603A1AB90 -Dtests.locale=en-PH -Dtests.timezone=Asia/Aqtau -Druntime.java=17

Does it reproduce?

Yes

Applicable branches

master

Failure history

I just caused it

Failure excerpt

 java.lang.AssertionError: Failure at [tsdb/05_dimension_and_metric_in_non_tsdb_index:239]: expected [2xx] status code but api [index] returned [400 Bad Request] [{"error":{"root_cause":[{"type":"mapper_parsing_exception","reason":"failed to parse field [nested.dim] of type [keyword] in document with id 'yF2M-n4BxnJzvZeHLUG1'. Preview of field's value: 'bar'","stack_trace":"org.elasticsearch.index.mapper.MapperParsingException: failed to parse field [nested.dim] of type [keyword] in document with id 'yF2M-n4BxnJzvZeHLUG1'. Preview of field's value: 'bar'\n\tat org.elasticsearch.index.mapper.FieldMapper.parse(FieldMapper.java:254)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseObjectOrField(DocumentParser.java:356)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseValue(DocumentParser.java:508)\n\tat org.elasticsearch.index.mapper.DocumentParser.innerParseObject(DocumentParser.java:296)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseObjectOrNested(DocumentParser.java:260)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseObjectOrField(DocumentParser.java:354)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseObject(DocumentParser.java:387)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseNonDynamicArray(DocumentParser.java:470)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseArray(DocumentParser.java:428)\n\tat org.elasticsearch.index.mapper.DocumentParser.innerParseObject(DocumentParser.java:284)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseObjectOrNested(DocumentParser.java:260)\n\tat org.elasticsearch.index.mapper.DocumentParser.internalParseDocument(DocumentParser.java:118)\n\tat org.elasticsearch.index.mapper.DocumentParser.parseDocument(DocumentParser.java:80)\n\tat org.elasticsearch.index.mapper.DocumentMapper.parse(DocumentMapper.java:80)\n\tat org.elasticsearch.index.shard.IndexShard.prepareIndex(IndexShard.java:998)\n\tat org.elasticsearch.index.shard.IndexShard.applyIndexOperation(IndexShard.java:947)\n\tat org.elasticsearch.index.shard.IndexShard.applyIndexOperationOnPrimary(IndexShard.java:891)\n\tat org.elasticsearch.action.bulk.TransportShardBulkAction.executeBulkItemRequest(TransportShardBulkAction.java:320)\n\tat org.elasticsearch.action
@nik9000 nik9000 added >test-failure Triaged test failures from CI needs:triage Requires assignment of a team area label :StorageEngine/TSDB You know, for Metrics labels Feb 14, 2022
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 14, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@nik9000 nik9000 removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:triage Requires assignment of a team area label labels Feb 14, 2022
@nik9000 nik9000 self-assigned this Feb 14, 2022
@weizijun weizijun mentioned this issue Feb 15, 2022
Merged
@weizijun
Copy link
Contributor

This will be fixed in #83920.

nik9000 pushed a commit that referenced this issue Feb 17, 2022
@weizijun
TSDB: Reject the nested object fields that are configured time_series…
c84c7d4 
…_dimension (#83920)

At the moment we really don't know what configuring a
`time_series_dimension` should *do* when there are nested documents.
So, for now, we're going to disable it. One day when someone has a good
idea of how it should work we can build that. But for now we don't want
to guess wrong and then lock us into some annoying behavior that no one
needs but we have to support for backwards compatibility reasons.

Closes: #83915
probakowski pushed a commit to probakowski/elasticsearch that referenced this issue Feb 23, 2022
@weizijun @probakowski
TSDB: Reject the nested object fields that are configured time_series…
ec2ecc9 
…_dimension (elastic#83920)

At the moment we really don't know what configuring a
`time_series_dimension` should *do* when there are nested documents.
So, for now, we're going to disable it. One day when someone has a good
idea of how it should work we can build that. But for now we don't want
to guess wrong and then lock us into some annoying behavior that no one
needs but we have to support for backwards compatibility reasons.

Closes: elastic#83915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nik9000 nik9000

Labels
:StorageEngine/TSDB You know, for Metrics >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
3 participants
@nik9000 @weizijun @elasticmachine