Calling user-defined methods within an if/else block in a lambda causes a failure #82224

jdconrad · 2022-01-04T18:20:48Z

It appears the "this" pointer doesn't get propagated into sub-scopes within a lambda causing a failure.

Reproduce:

int test1() {
  return 1;
} 

void test(Map params) {
  int i = 0; 
  params.forEach( (k, v) -> {
    if (i == 0) {
      test1()
    } else {
      test1()
    }
  } ) 
} 

test(params)

Error:
no 'this' pointer within static method

Workaround:

Use control-flow logic such as if/else, for, and while to replace the lambda causing an issue.

After #74268, all user functions are instance methods, so the this reference needs to be propagated.

The text was updated successfully, but these errors were encountered:

elasticmachine · 2022-01-04T18:20:50Z

Pinging @elastic/es-core-infra (Team:Core/Infra)

If a lambda contains a block that calls into a user function, the painless compiler was not tracking that the lambda needs to capture the `this` pointer. Scripts that attempted to use a lambda that calls a user function from inside a block would trigger an `illegal_state_exception`: > no 'this' pointer within static method `BlockScope` now forwards `setUsesInstanceMethod` calls to it's parent, which may be a `LambdaScope`. `LambdaScope` will also forward `setUsesInstanceMethod` to it's parent after setting it's own `usesInstanceMethod` flag, Propagating `this` pointer capture in the case of nested lambdas. Fixes: elastic#82224

* Script: track this pointer capture from blocks within lambdas If a lambda contains a block that calls into a user function, the painless compiler was not tracking that the lambda needs to capture the `this` pointer. Scripts that attempted to use a lambda that calls a user function from inside a block would trigger an `illegal_state_exception`: > no 'this' pointer within static method `BlockScope` now forwards `setUsesInstanceMethod` calls to it's parent, which may be a `LambdaScope`. `LambdaScope` will also forward `setUsesInstanceMethod` to it's parent after setting it's own `usesInstanceMethod` flag, propagating `this` pointer capture in the case of nested lambdas. Fixes: #82224

…c#82228) * Script: track this pointer capture from blocks within lambdas If a lambda contains a block that calls into a user function, the painless compiler was not tracking that the lambda needs to capture the `this` pointer. Scripts that attempted to use a lambda that calls a user function from inside a block would trigger an `illegal_state_exception`: > no 'this' pointer within static method `BlockScope` now forwards `setUsesInstanceMethod` calls to it's parent, which may be a `LambdaScope`. `LambdaScope` will also forward `setUsesInstanceMethod` to it's parent after setting it's own `usesInstanceMethod` flag, propagating `this` pointer capture in the case of nested lambdas. Fixes: elastic#82224

#82235) * Script: track this pointer capture from blocks within lambdas If a lambda contains a block that calls into a user function, the painless compiler was not tracking that the lambda needs to capture the `this` pointer. Scripts that attempted to use a lambda that calls a user function from inside a block would trigger an `illegal_state_exception`: > no 'this' pointer within static method `BlockScope` now forwards `setUsesInstanceMethod` calls to it's parent, which may be a `LambdaScope`. `LambdaScope` will also forward `setUsesInstanceMethod` to it's parent after setting it's own `usesInstanceMethod` flag, propagating `this` pointer capture in the case of nested lambdas. Fixes: #82224

…82228) (#82237) * Script: track this pointer capture from blocks within lambdas (#82228) * Script: track this pointer capture from blocks within lambdas If a lambda contains a block that calls into a user function, the painless compiler was not tracking that the lambda needs to capture the `this` pointer. Scripts that attempted to use a lambda that calls a user function from inside a block would trigger an `illegal_state_exception`: > no 'this' pointer within static method `BlockScope` now forwards `setUsesInstanceMethod` calls to it's parent, which may be a `LambdaScope`. `LambdaScope` will also forward `setUsesInstanceMethod` to it's parent after setting it's own `usesInstanceMethod` flag, propagating `this` pointer capture in the case of nested lambdas. Fixes: #82224 * org.elasticsearch.core.Map.of

…82228) (#82236) * Script: track this pointer capture from blocks within lambdas (#82228) * Script: track this pointer capture from blocks within lambdas If a lambda contains a block that calls into a user function, the painless compiler was not tracking that the lambda needs to capture the `this` pointer. Scripts that attempted to use a lambda that calls a user function from inside a block would trigger an `illegal_state_exception`: > no 'this' pointer within static method `BlockScope` now forwards `setUsesInstanceMethod` calls to it's parent, which may be a `LambdaScope`. `LambdaScope` will also forward `setUsesInstanceMethod` to it's parent after setting it's own `usesInstanceMethod` flag, propagating `this` pointer capture in the case of nested lambdas. Fixes: #82224 * org.elasticsearch.core.Map.of

…c#82228) * Script: track this pointer capture from blocks within lambdas If a lambda contains a block that calls into a user function, the painless compiler was not tracking that the lambda needs to capture the `this` pointer. Scripts that attempted to use a lambda that calls a user function from inside a block would trigger an `illegal_state_exception`: > no 'this' pointer within static method `BlockScope` now forwards `setUsesInstanceMethod` calls to it's parent, which may be a `LambdaScope`. `LambdaScope` will also forward `setUsesInstanceMethod` to it's parent after setting it's own `usesInstanceMethod` flag, propagating `this` pointer capture in the case of nested lambdas. Fixes: elastic#82224

jdconrad added >bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache labels Jan 4, 2022

elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 4, 2022

stu-elastic added >regression v7.15.0 v7.15.1 v7.15.2 v7.15.3 v7.16.0 v7.16.1 v7.16.2 labels Jan 4, 2022

stu-elastic mentioned this issue Jan 4, 2022

Script: track this pointer capture from blocks within lambdas #82228

Merged

stu-elastic closed this as completed in #82228 Jan 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Calling user-defined methods within an if/else block in a lambda causes a failure #82224

Calling user-defined methods within an if/else block in a lambda causes a failure #82224

jdconrad commented Jan 4, 2022 •

edited by stu-elastic

Loading

elasticmachine commented Jan 4, 2022

Calling user-defined methods within an if/else block in a lambda causes a failure #82224

Calling user-defined methods within an if/else block in a lambda causes a failure #82224

Comments

jdconrad commented Jan 4, 2022 • edited by stu-elastic Loading

elasticmachine commented Jan 4, 2022

jdconrad commented Jan 4, 2022 •

edited by stu-elastic

Loading