Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not emit elastic_product_origin when value is empty #81757

Closed
pgomulka opened this issue Dec 15, 2021 · 1 comment · Fixed by #111683
Closed

Do not emit elastic_product_origin when value is empty #81757

pgomulka opened this issue Dec 15, 2021 · 1 comment · Fixed by #111683
Assignees
@rjernst
Labels
>bug :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v8.0.0 v8.16.0

Comments

@pgomulka
Copy link
Contributor

In deprecation logs when elastic_product_origin is empty the field is emitted anyway

"elasticsearch.elastic_product_origin":""

The same applies to indexed deprecation logs.
We should fix the deprecation message to only emit a field if the value is not empty

This affects 8.1 and 8.0.
Should not affect 7.16 (just by looking at the code) but should be confirmed
@pgomulka pgomulka added >bug :Core/Infra/Logging Log management and logging utilities v8.0.0 v8.1.0 labels Dec 15, 2021
@pgomulka pgomulka self-assigned this Dec 15, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Dec 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@csoulios csoulios added v8.6.0 and removed v8.5.0 labels Sep 21, 2022
@kingherc kingherc added v8.7.0 and removed v8.6.0 labels Nov 16, 2022
@rjernst rjernst added v8.8.0 and removed v8.7.0 labels Feb 8, 2023
@gmarouli gmarouli added v8.9.0 and removed v8.8.0 labels Apr 26, 2023
@quux00 quux00 added v8.11.0 and removed v8.10.0 labels Aug 16, 2023
@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@rjernst rjernst assigned rjernst and unassigned pgomulka Aug 7, 2024
rjernst added a commit to rjernst/elasticsearch that referenced this issue Aug 7, 2024
@rjernst
Only emit product origin in deprecation log if present
3ad8334 
The elastic product origin may not always be present when deprecation
messages are emitted. This commit changes the log message created for
deprecations to only emit the product origin field if it is not empty.

closes elastic#81757
@rjernst rjernst mentioned this issue Aug 7, 2024
Merged
@rjernst rjernst closed this as completed in b31feb3 Aug 8, 2024
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Sep 4, 2024
@rjernst @cbuescher
Only emit product origin in deprecation log if present (elastic#111683)
7d54075 
The elastic product origin may not always be present when deprecation
messages are emitted. This commit changes the log message created for
deprecations to only emit the product origin field if it is not empty.

closes elastic#81757
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this issue Sep 5, 2024
@rjernst @davidkyle
Only emit product origin in deprecation log if present (elastic#111683)
fb88edb 
The elastic product origin may not always be present when deprecation
messages are emitted. This commit changes the log message created for
deprecations to only emit the product origin field if it is not empty.

closes elastic#81757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjernst rjernst

Labels
>bug :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v8.0.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only emit product origin in deprecation log if present rjernst/elasticsearch