Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo bounds aggregation: Add support for geo_shape. #7574

Closed
yeroc opened this issue Sep 3, 2014 · 43 comments
Closed

geo bounds aggregation: Add support for geo_shape. #7574

yeroc opened this issue Sep 3, 2014 · 43 comments
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@yeroc
Copy link

yeroc commented Sep 3, 2014

Some time ago I created an enhancement request to support a bounding box aggregation (#5634) as this is very useful for mapping applications to allow a map to zoom to the extent (bounding box) of all matches. This was implemented in v1.3.0 but unfortunately only for the geo_point type.
@clintongormley
Copy link
Contributor

@colings86 what do you think?

@emmanuelmathot
Copy link

I would find this feature very useful as well. We would generate density maps from those aggregation!

@clintongormley clintongormley added :Analytics/Geo Indexing, search aggregations of geo points and shapes discuss labels Nov 10, 2014
@pierrecdn pierrecdn mentioned this issue Jan 9, 2015
Closed
@yeroc
Copy link
Author

yeroc commented Jan 14, 2015

Any update on this? Does this require some additional features in Lucene or does this require changes to ElasticSearch only?

@nknize
Copy link
Contributor

nknize commented Jan 15, 2015

No additional Lucene features required to support this feature. I'm currently refactoring some legacy geo_point code to reuse geo_shape logic that fixes polygonal ambiguity issues. Once that's done adding support for this request will be relatively straight-forward.

@yeroc
Copy link
Author

yeroc commented Jan 15, 2015

@nknize Thanks a lot for the update.

@emmanuelmathot
Copy link

Great

@emmanuelmathot
Copy link

Any planned date for release?

@clintongormley
Copy link
Contributor

@nknize just assigned this to you so you don't miss it

@lestarcdog lestarcdog mentioned this issue Jul 10, 2015
Open
@clintongormley
Copy link
Contributor

@nknize just pinging for an update on this.

@carlosvega
Copy link

+1

@nknize
Copy link
Contributor

nknize commented Nov 27, 2015

2.2 for sure and can be back ported to 2.0+ (@clintongormley thoughts on back porting?).

@clintongormley
Copy link
Contributor

@nknize new features/enhancements go into the current stable branch and above only (ie 2.2+ at the moment)

@spinscale spinscale added v2.3.0 and removed v2.2.0 labels Dec 23, 2015
@samchorlton
Copy link

What is the latest on this?

@nknize
Copy link
Contributor

nknize commented Mar 24, 2016

This was put on hold to prioritize spatial indexing performance issues in lucene 6.0. Once we get that stable this will move back up in the list.

@samchorlton
Copy link

Ok cool thanks for letting me know. Do you know if this will add support to allow aggregation of geoshape polygons or is this just for aggregation of points by polygons?

@hanoch
Copy link

hanoch commented Nov 14, 2017

@clintongormley when is the "BKD-backed geoshapes" planned to be merged?

@clintongormley
Copy link
Contributor

@hanoch when it is ready. I can't be any more specific than that

@bilalvdemir
Copy link

bilalvdemir commented Jan 18, 2018 •
edited
Loading

Hi, this feature has complate? @clintongormley

@BrianDMay
Copy link

+1

1 similar comment
@abuddenb
Copy link

+1

@hanoch
Copy link

hanoch commented Jul 6, 2018

any progress on that?

@refaelasraf
Copy link

Have any updates on that ?

@hanoch
Copy link

hanoch commented Nov 15, 2018

@nknize
is this now addressed with the ES 6.5.0 release and #32730 PR merge?

@imotov
Copy link
Contributor

imotov commented Dec 10, 2018

@hanoch no, we still need get #32039 in first

@imotov imotov added the stalled label Dec 10, 2018
@nknize
Copy link
Contributor

nknize commented Dec 10, 2018 •
edited
Loading

We also won't be able to add geo_shape aggregations until we come up w/ a reasonable doc value representation for geo_shape. WKB seems the best option at the moment but we need to investigate docValue size limits in lucene.

It is possible that we will need to limit the number of shape vertices to comply w/ Lucene docValue size limits for geo_shape fields that have docValues enabled. /brainstorm /cc @jpountz

@talevy talevy removed their assignment Dec 11, 2018
@imotov
Copy link
Contributor

imotov commented Jan 7, 2019

Depends on #37206

@babadofar
Copy link

Apparently Kibana believes this has been fixed already. See this bug report
elastic/kibana#31589

@thomasneirynck thomasneirynck mentioned this issue Feb 20, 2019
Closed
@thomasneirynck
Copy link
Contributor

This is a requirement to be able to do layer-fitting on layers backed by geo_shape fields in the maps app. cf. elastic/kibana#33509

@thomasneirynck thomasneirynck mentioned this issue Mar 19, 2019
Closed
fxprunayre added a commit to fxprunayre/core-geonetwork that referenced this issue Mar 28, 2019
@fxprunayre
WFS Feature / Zoom to filtered results.
31ff425 
    When indexing features, add 4 fields to store the coordinate of the
    bounding box of each features. On client side use min/max aggregations
    to retrieve the bounding box of all features matching filter.

    When ES support for geo_bounds aggregation will be implemented for geo_shape type
    See elastic/elasticsearch#7574
    The following would be better probably:

    ```
     "viewport" : {
       "geo_bounds" : {
         "field" : "location",
         "wrap_longitude" : true
       }
     }
    ```
@imotov imotov mentioned this issue Apr 11, 2019
Closed
fxprunayre added a commit to geonetwork/core-geonetwork that referenced this issue May 14, 2019
@fxprunayre
WFS Feature / Zoom to filtered results. (#3701)
24ee908 
* WFS Feature / Zoom to filtered results.

    When indexing features, add 4 fields to store the coordinate of the
    bounding box of each features. On client side use min/max aggregations
    to retrieve the bounding box of all features matching filter.

    When ES support for geo_bounds aggregation will be implemented for geo_shape type
    See elastic/elasticsearch#7574
    The following would be better probably:

    ```
     "viewport" : {
       "geo_bounds" : {
         "field" : "location",
         "wrap_longitude" : true
       }
     }
    ```

* WFS Feature / Zoom to filtered results / Zoom when applying filters too.

* WFS Feature / Clean up sort issue. Do not zoom to on empty aggs.

* WFS / Only use regex filter on string type.

* WFS / Only use regex filter on string type.

* WFS / Zoom to point with a buffer.

* WFS / Fix heatmap index requests
@hanoch
Copy link

hanoch commented Aug 20, 2019

Any progress on this issue? any ETA?

@talevy
Copy link
Contributor

talevy commented Aug 20, 2019

@hanoch there is some progress. there is a feature branch that this issue is tracking: #37206.

The feature branch has partial support for aggregations for now, one being geo_bounds: #45413

Unfortunately, I cannot share an ETA for this work, but I can say that it is actively being worked on!

@rjernst rjernst added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 4, 2020
@talevy
Copy link
Contributor

talevy commented May 8, 2020

this was implemented in #55328!

@talevy talevy closed this as completed May 8, 2020
@nknize nknize removed the stalled label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests