Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aggregations] Need a deprecation message for the percentiles parameter not allowing duplicate values #65240

Closed
cuff-links opened this issue Nov 18, 2020 · 2 comments
Assignees
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@cuff-links
Copy link

Summary

When we perform a query in 7.x with an aggregation, the percentiles parameter allows for an array of numbers. As per the docs, in 8.0, all of those values must be unique. Currently, we allow for duplicate values but we should be getting a deprecation warning. There is no warning.

Source

https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html#breaking_80_aggregations_changes

How to Test

Run the following query in Dev Console:

GET latency/_search
{
  "size": 0,
  "aggs": {
    "load_time_outlier": {
      "percentiles": {
        "field": "load_time" ,
        "percents": [
          1,
          1,
          5,
          25,
          50,
          75,
          95,
          99
        ]
      }
    }
  }
}

Check the deprecation logs for a message.

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@hendrikmuhs
Copy link

fixed by #65252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

3 participants