Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "experimental-ish" language in HDR Histo percentiles/ranks #60780

Closed
polyfractal opened this issue Aug 5, 2020 · 3 comments · Fixed by #81773
Closed

Remove "experimental-ish" language in HDR Histo percentiles/ranks #60780

polyfractal opened this issue Aug 5, 2020 · 3 comments · Fixed by #81773
Assignees
@wchaparro
Labels
:Analytics/Aggregations Aggregations >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team

Comments

@polyfractal
Copy link
Contributor

Percentiles and Ranks have "experimental-ish" language which suggests we might change the syntax:

Note: This setting exposes the internal implementation of HDR Histogram and the syntax may change in the future.

I believe this was added when percentiles was upgraded to GA, because there was some concern we were leaking implementation details to the user. While that's true, I'm not sure I see an alternative (e.g. TDigest and HDR operate sufficiently different that it would be hard to generalize some kind of "precision" parameter between the two, and gets harder if we ever add new algorithms). It has also been 4+ years since the language was added so I think it's not really accurate anymore. The feature is fairly "stable" at this point, at least with regards to syntax.

I'd like to propose we remove these warnings.
@polyfractal polyfractal added >docs General docs changes :Analytics/Aggregations Aggregations team-discuss labels Aug 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Aug 5, 2020
@timroes timroes mentioned this issue Sep 22, 2020
Closed
@wchaparro
Copy link
Member

We discussed this in our team sync, and we agree we should remove the experimental language.

wchaparro added a commit that referenced this issue Dec 15, 2021
@wchaparro
[DOCS] Remove experimental language from HDR Histo percentiles/ranks
0d660eb 
per issue 60780, decision from team to remove experimental language from HDR Histogram percentiles and ranks. Feature has been in production for quite some time.
closes #60780
@wchaparro wchaparro mentioned this issue Dec 15, 2021
Merged
wchaparro added a commit that referenced this issue Dec 15, 2021
@wchaparro
[DOCS] Remove experimental language from HDR Histo percentiles/ranks (#…
c8e8104 
…81773)

per issue 60780, decision from team to remove experimental language from HDR Histogram percentiles and ranks. Feature has been in production for quite some time.
closes #60780
@wchaparro wchaparro self-assigned this Dec 15, 2021
elasticsearchmachine pushed a commit that referenced this issue Dec 15, 2021
@jrodewig @wchaparro
[DOCS] Remove experimental language from HDR Histo percentiles/ranks (#…
353aed5 
…81773) (#81784)

per issue 60780, decision from team to remove experimental language from HDR Histogram percentiles and ranks. Feature has been in production for quite some time.
closes #60780

Co-authored-by: William Chaparro <[email protected]>
elasticsearchmachine pushed a commit that referenced this issue Dec 15, 2021
@jrodewig @wchaparro
[DOCS] Remove experimental language from HDR Histo percentiles/ranks (#…
6e99c86 
…81773) (#81785)

per issue 60780, decision from team to remove experimental language from HDR Histogram percentiles and ranks. Feature has been in production for quite some time.
closes #60780

Co-authored-by: William Chaparro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wchaparro wchaparro

Labels
:Analytics/Aggregations Aggregations >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DOCS] Remove experimental language from HDR Histo percentiles/ranks elastic/elasticsearch
3 participants
@polyfractal @wchaparro @elasticmachine