Source filtering with wildcards broken when given multiple patterns #5132
Assignees
Comments
|
Agreed. I can reproduce it and fix it. BTW, you can send PR if you think it fixes thing and we will be happy to comment on PR if there is anything wrong or if it needs some modification. :-) Thanks! |
dadoonet
added a commit
to dadoonet/elasticsearch
that referenced
this issue
Feb 15, 2014
```
curl -XPUT 'http://localhost:9200/twitter/tweet/1' -d '{
"user" : "kimchy",
"post_date" : "2009-11-15T14:12:12",
"message" : "trying out Elasticsearch", "retweeted": false
}'
```
No source fields delivered:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=*.id,retweeted&pretty=yes'
```
`retweeted` returned:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=retweeted,*.id&pretty=yes'
```
Closes elastic#5132.
|
Tests pass with the modification. PR #5133 created with a fix and a test. |
dadoonet
added a commit
that referenced
this issue
Feb 17, 2014
```
curl -XPUT 'http://localhost:9200/twitter/tweet/1' -d '{
"user" : "kimchy",
"post_date" : "2009-11-15T14:12:12",
"message" : "trying out Elasticsearch", "retweeted": false
}'
```
No source fields delivered:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=*.id,retweeted&pretty=yes'
```
`retweeted` returned:
```
curl -XGET 'http://localhost:9200/twitter/tweet/1?_source=retweeted,*.id&pretty=yes'
```
Closes #5132.
Closes #5133.
(cherry picked from commit 5d15936)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No source fields delivered:
retweetedreturned:This happens because the filter breaks out of the loop instead of continuing to check whether any of the other
includesmay match. Replacing thebreakwith acontinuefixes this. But I hesitate to submit a pull request because I didn't have time to fully understand this code.I understand that this is a corner case but it's a new feature in 1.0 and the example in the documentation does not work due to this bug.
The text was updated successfully, but these errors were encountered: