Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Failure in org.elasticsearch.xpack.watcher.transport.action.activate.ActivateWatchTests » testDeactivateAndActivate #47503

Closed
original-brownbear opened this issue Oct 3, 2019 · 1 comment · Fixed by #47630
Closed

[CI] Failure in org.elasticsearch.xpack.watcher.transport.action.activate.ActivateWatchTests » testDeactivateAndActivate #47503

original-brownbear opened this issue Oct 3, 2019 · 1 comment · Fixed by #47630
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI

Comments

@original-brownbear
Copy link
Member

See https://gradle-enterprise.elastic.co/s/y4qzgh4jn3cui/tests/b7fudwgbez7dk-llyelukd2frze?openStackTraces=WzBd


2> REPRODUCE WITH: ./gradlew ':x-pack:plugin:watcher:test' --tests "org.elasticsearch.xpack.watcher.transport.action.activate.ActivateWatchTests.testDeactivateAndActivate" -Dtests.seed=4322F53189AC999A -Dtests.security.manager=true -Dtests.locale=ig -Dtests.timezone=CET -Dcompiler.java=12 -Druntime.java=11

ran into


2> java.lang.AssertionError: Watcher should have stopped executing but new history found
--
at __randomizedtesting.SeedInfo.seed([4322F53189AC999A:E37A8DCC46F54FE6]:0)
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.elasticsearch.xpack.watcher.transport.action.activate.ActivateWatchTests.testDeactivateAndActivate(ActivateWatchTests.java:95)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Features)

jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Oct 6, 2019
@jakelandis
Watcher remove assertion that is susceptible to a race condition
957f05a 
When deactivating a watch, there is a chance that it is fully deactivated
and reporting as not running but the history is not fully written yet.
There is not a tight coupling between the associated watcher history
index and the deactivation. This test assumes that once a watch is
deactivated that all history is fully written in a very short time period.
If the Watch is deactivated, but the history is slow to write it can result
in a failing test.

This change removes an assertion that assumes that the deactivation of a watch
ensured the all of the watch history was written. There is still a minor race
condition with respect to the remaining history assertions. However, if the
history is slow to be written, it will allow the test to still passing.

fixes elastic#47503
@jakelandis jakelandis mentioned this issue Oct 6, 2019
Merged
jakelandis added a commit that referenced this issue Oct 7, 2019
@jakelandis
Watcher remove assertion that is susceptible to a race condition (#47630
6e98189 
)

When deactivating a watch, there is a chance that it is fully deactivated
and reporting as not running but the history is not fully written yet.
There is not a tight coupling between the associated watcher history
index and the deactivation. This test assumes that once a watch is
deactivated that all history is fully written in a very short time period.
If the Watch is deactivated, but the history is slow to write it can result
in a failing test.

This change removes an assertion that assumes that the deactivation of a watch
ensured the all of the watch history was written. There is still a minor race
condition with respect to the remaining history assertions. However, if the
history is slow to be written, it will allow the test to still passing.

fixes #47503
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Oct 7, 2019
@jakelandis
Watcher remove assertion that is susceptible to a race condition (ela…
b327e7a 
…stic#47630)

When deactivating a watch, there is a chance that it is fully deactivated
and reporting as not running but the history is not fully written yet.
There is not a tight coupling between the associated watcher history
index and the deactivation. This test assumes that once a watch is
deactivated that all history is fully written in a very short time period.
If the Watch is deactivated, but the history is slow to write it can result
in a failing test.

This change removes an assertion that assumes that the deactivation of a watch
ensured the all of the watch history was written. There is still a minor race
condition with respect to the remaining history assertions. However, if the
history is slow to be written, it will allow the test to still passing.

fixes elastic#47503
@jakelandis jakelandis mentioned this issue Oct 7, 2019
Merged
jakelandis added a commit to jakelandis/elasticsearch that referenced this issue Oct 7, 2019
@jakelandis
Watcher remove assertion that is susceptible to a race condition (ela…
a9fb947 
…stic#47630)

When deactivating a watch, there is a chance that it is fully deactivated
and reporting as not running but the history is not fully written yet.
There is not a tight coupling between the associated watcher history
index and the deactivation. This test assumes that once a watch is
deactivated that all history is fully written in a very short time period.
If the Watch is deactivated, but the history is slow to write it can result
in a failing test.

This change removes an assertion that assumes that the deactivation of a watch
ensured the all of the watch history was written. There is still a minor race
condition with respect to the remaining history assertions. However, if the
history is slow to be written, it will allow the test to still passing.

fixes elastic#47503
@jakelandis jakelandis mentioned this issue Oct 7, 2019
Merged
jakelandis added a commit that referenced this issue Oct 7, 2019
@jakelandis
Watcher remove assertion that is susceptible to a race conditi… (#47667)
a49a1b6 
When deactivating a watch, there is a chance that it is fully deactivated
and reporting as not running but the history is not fully written yet.
There is not a tight coupling between the associated watcher history
index and the deactivation. This test assumes that once a watch is
deactivated that all history is fully written in a very short time period.
If the Watch is deactivated, but the history is slow to write it can result
in a failing test.

This change removes an assertion that assumes that the deactivation of a watch
ensured the all of the watch history was written. There is still a minor race
condition with respect to the remaining history assertions. However, if the
history is slow to be written, it will allow the test to still passing.

fixes #47503
jakelandis added a commit that referenced this issue Oct 8, 2019
@jakelandis
Watcher remove assertion that is susceptible to a race conditi… (#47670)
79a787f 
When deactivating a watch, there is a chance that it is fully deactivated
and reporting as not running but the history is not fully written yet.
There is not a tight coupling between the associated watcher history
index and the deactivation. This test assumes that once a watch is
deactivated that all history is fully written in a very short time period.
If the Watch is deactivated, but the history is slow to write it can result
in a failing test.

This change removes an assertion that assumes that the deactivation of a watch
ensured the all of the watch history was written. There is still a minor race
condition with respect to the remaining history assertions. However, if the
history is slow to be written, it will allow the test to still passing.

fixes #47503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Watcher remove assertion that is susceptible to a race condition jakelandis/elasticsearch
3 participants
@jakelandis @original-brownbear @elasticmachine