-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport's publish address should report its hostname #39970
Labels
Comments
DaveCTurner
added
>bug
:Distributed Coordination/Network
Http and internode communication implementations
labels
Mar 12, 2019
Pinging @elastic/es-distributed |
andrershov
pushed a commit
to andrershov/elasticsearch
that referenced
this issue
Aug 15, 2019
andrershov
pushed a commit
to andrershov/elasticsearch
that referenced
this issue
Aug 15, 2019
andrershov
pushed a commit
that referenced
this issue
Aug 16, 2019
andrershov
pushed a commit
that referenced
this issue
Aug 16, 2019
andrershov
pushed a commit
that referenced
this issue
Aug 22, 2019
…erty is specified (#45662) Follow-up of #45626. Now we always output transport.publish_address with CNAME and log deprecation warning if es.transport.cname_in_publish_address property is specified. This commit also adds a test which will fail once Elasticsearch version is changed to 9, to make sure we remove the property when doing reversioning. Closes #39970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
There are situations in which the hostname of the transport's publish address is important. For instance, if node-to-node TLS is enabled including full certificate verification then it is the hostname of the node's publish address that we are verifying.
I suspect that #32729 was raised because we hide the hostname of the publish address. This log message was quoted as an example of the problem:
However this does not indicate that the hostname is lost. We simply don't show it. The same is true in the output from
GET _nodes
:Similar to #32806, I think we should expose the hostname in these addresses to clarify that it's still there and to aid troubleshooting when setting up full certificate verification.
The text was updated successfully, but these errors were encountered: