Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PUT mapping with _doc on an index that has types" fails #38202

Closed
dnhatn opened this issue Feb 1, 2019 · 3 comments
Closed

"PUT mapping with _doc on an index that has types" fails #38202

dnhatn opened this issue Feb 1, 2019 · 3 comments
Assignees
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Feb 1, 2019

This test fails twice after it was backported into 6.x today.

We expect the test fails with "the final mapping would have more than 1 type" but the actual reason is "Document mapping type name can't start with '_', found: [_doc]".

FAILURE 0.29s | MixedClusterClientYamlTestSuiteIT.test {p0=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types} <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: Failure at [indices.put_mapping/20_mix_typeless_typeful:73]: the error message was expected to match the provided regex but didn't
   > Expected: the final mapping would have more than 1 type
   >      but: was "{root_cause=[{type=invalid_type_name_exception, reason=Document mapping type name can't start with '_', found: [_doc], stack_trace=InvalidTypeNameException[Document mapping type name can't start with '_', found: [_doc]]\n\tat 

I can reproduce this after around 10 runs.

./gradlew :qa:mixed-cluster:v6.0.1#mixedClusterTestRunner   \
-Dtests.seed=A3A03AA8BC85CA20   \
-Dtests.class=org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT   \
-Dtests.method="test {p0=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types}"   \
-Dtests.security.manager=true   \
-Dtests.locale=de-GR   \
-Dtests.timezone=Asia/Baghdad   \
-Dcompiler.java=11   \
-Druntime.java=8

Relates #37871

CI: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+internalClusterTest/284/console

@dnhatn dnhatn added :Search Foundations/Mapping Index mappings, including merging and defining field types >test-failure Triaged test failures from CI labels Feb 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jpountz
Copy link
Contributor

jpountz commented Feb 1, 2019

Thanks @dnhatn I'll look.

jpountz added a commit to jpountz/elasticsearch that referenced this issue Feb 18, 2019
The test assumed that it could run against all 6.x indices but it actually
requires 6.2+ since 6.2 is the first version that allowed `_doc` as a type
name (elastic#27816).

Closes elastic#38202
jpountz added a commit that referenced this issue Feb 20, 2019
…`. (#39054)

The test assumed that it could run against all 6.x indices but it actually
requires 6.2+ since 6.2 is the first version that allowed `_doc` as a type
name (#27816).

Closes #38202
@jpountz
Copy link
Contributor

jpountz commented Mar 25, 2019

Closed via #39054

@jpountz jpountz closed this as completed Mar 25, 2019
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

4 participants