-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] AssertionError in ShardSearchStats #37185
Labels
:Search/Search
Search-related issues that do not fall into other categories
>test-failure
Triaged test failures from CI
v7.2.0
v8.0.0-alpha1
Comments
Pinging @elastic/es-search |
s1monw
added a commit
to s1monw/elasticsearch
that referenced
this issue
Jan 15, 2019
…called Today we have several implementations of executing SearchOperationListener in SearchService. While all of them seem to be safe at least on, the one that executes scroll searches can cause illegal execution of SearchOperationListener that can then in-turn trigger assertions in ShardSearchStats. This change adds a SearchOperationListenerExecutor that uses try-with blocks to ensure listeners are called in a safe way. Relates to elastic#37185
s1monw
added a commit
that referenced
this issue
Jan 23, 2019
…called (#37467) Today we have several implementations of executing SearchOperationListener in SearchService. While all of them seem to be safe at least on, the one that executes scroll searches can cause illegal execution of SearchOperationListener that can then in-turn trigger assertions in ShardSearchStats. This change adds a SearchOperationListenerExecutor that uses try-with blocks to ensure listeners are called in a safe way. Relates to #37185
s1monw
added a commit
that referenced
this issue
Jan 23, 2019
…called (#37467) Today we have several implementations of executing SearchOperationListener in SearchService. While all of them seem to be safe at least on, the one that executes scroll searches can cause illegal execution of SearchOperationListener that can then in-turn trigger assertions in ShardSearchStats. This change adds a SearchOperationListenerExecutor that uses try-with blocks to ensure listeners are called in a safe way. Relates to #37185
we just spoke about this again and decided to close it since we added infra to prevent it in #37467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Search/Search
Search-related issues that do not fall into other categories
>test-failure
Triaged test failures from CI
v7.2.0
v8.0.0-alpha1
A 6.6 ML test timed out in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.6+matrix-java-periodic/ES_BUILD_JAVA=java11,ES_RUNTIME_JAVA=zulu11,nodes=virtual&&linux/38/consoleText because the thread that was initializing a scroll threw an assertion error:
The REPRO command is this:
However, it doesn't reproduce locally for me.
The scroll that was being initialized when this happened is the one that is set up in
elasticsearch/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/persistence/BatchedDocumentsIterator.java
Lines 94 to 103 in 0000e7c
The text was updated successfully, but these errors were encountered: