Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Literals should be made NamedExpressions #33523

Closed
costin opened this issue Sep 7, 2018 · 1 comment
Closed

SQL: Literals should be made NamedExpressions #33523

costin opened this issue Sep 7, 2018 · 1 comment
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v7.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Sep 7, 2018

As Literals can and are used inside queries, similar to Functions they should become NamedExpressions so they can carry their own name and not have to be hidden behind Aliases.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@costin costin mentioned this issue Sep 7, 2018
Merged
costin added a commit to costin/elasticsearch that referenced this issue Sep 10, 2018
@costin
SQL: Make Literal a NamedExpression
29300af 
Literal now is a NamedExpression reducing the need for Aliases for
folded expressions leading to simpler optimization rules.

Fix elastic#33523
@costin costin mentioned this issue Sep 10, 2018
Merged
costin added a commit that referenced this issue Sep 11, 2018
@costin
SQL: Make Literal a NamedExpression (#33583)
91bca17 
* SQL: Make Literal a NamedExpression

Literal now is a NamedExpression reducing the need for Aliases for
folded expressions leading to simpler optimization rules.

Fix #33523
costin added a commit that referenced this issue Sep 11, 2018
@costin
SQL: Make Literal a NamedExpression (#33583)
c771d46 
* SQL: Make Literal a NamedExpression

Literal now is a NamedExpression reducing the need for Aliases for
folded expressions leading to simpler optimization rules.

Fix #33523

(cherry picked from commit 91bca17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@costin @colings86 @elasticmachine