-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimpleKdcLdapServerTests.testPrincipalCreationAndSearchOnLdap fails sporadically #32739
Comments
@bizybot can you please track down this failure? |
Pinging @elastic/es-security |
The test SimpleKdcLdapServerTests#testPrincipalCreationAndSearchOnLdap fails intermittently and I could not reproduce this locally. There were two exceptions from the console logs of which one might be the reason for the failure. When simple kdc ldap server starts, internally it starts kdc server and ldap server. Kdc server then tries to connect to configured ldap backend and during this process it waits for the connection to succeed, meanwhile checking for deadlocks in between. During this deadlock check it needs permission to `accessClassInPackage.sun.reflect`, the fix here is to add the required permission so that the check does not throw exception. I think once we fix this issue, we may have something to look forward if there is indeed a deadlock or its just waiting for the process to complete on slow test runs. Added a null check in after test method. See elastic#32739
I am in process of moving these tests to evil-tests as it needs some permission which we do not want to enable on production. |
We have a test dependency on Apache Mina when using SimpleKdcServer for testing Kerberos. When checking for ldap backend connectivity, the code checks for deadlocks which require additional security permissions `accessClassInPackage.sun.reflect`. As this is only for test and we do not want to add security permissions to production, this commit moves these tests and related classes to x-pack evil-tests where they can run with security manager disabled. The plan is to handle the security manager exception in the upstream and then once the release is available run these tests with security manager enabled. Closes#32739
We have a test dependency on Apache Mina when using SimpleKdcServer for testing Kerberos. When checking for LDAP backend connectivity, the code checks for deadlocks which require additional security permissions accessClassInPackage.sun.reflect. As this is only for test and we do not want to add security permissions to production, this commit moves these tests and related classes to x-pack evil-tests where they can run with security manager disabled. The plan is to handle the security manager exception in the upstream issue DIRMINA-1093 and then once the release is available to run these tests with security manager enabled. Closes #32739
We have a test dependency on Apache Mina when using SimpleKdcServer for testing Kerberos. When checking for LDAP backend connectivity, the code checks for deadlocks which require additional security permissions accessClassInPackage.sun.reflect. As this is only for test and we do not want to add security permissions to production, this commit moves these tests and related classes to x-pack evil-tests where they can run with security manager disabled. The plan is to handle the security manager exception in the upstream issue DIRMINA-1093 and then once the release is available to run these tests with security manager enabled. Closes elastic#32739
We have another test failure on the 6.4 branch in https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.4+matrix-java-periodic/ES_BUILD_JAVA=java10,ES_RUNTIME_JAVA=java8fips,nodes=virtual&&linux/57/consoleFull and I think this is the same error:
I attempted to cherry-pick your changes to 6.4 but it does not apply cleanly. Can you please backport this to 6.4 @bizybot as you are probably more familiar with the changes than me? Thank you! |
We have a test dependency on Apache Mina when using SimpleKdcServer for testing Kerberos. When checking for LDAP backend connectivity, the code checks for deadlocks which require additional security permissions accessClassInPackage.sun.reflect. As this is only for test and we do not want to add security permissions to production, this commit moves these tests and related classes to x-pack evil-tests where they can run with security manager disabled. The plan is to handle the security manager exception in the upstream issue DIRMINA-1093 and then once the release is available to run these tests with security manager enabled. Closes #32739
Backported change to 6.4 (move SimpleKdc to evil-tests), closing this issue. |
Logs: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA=java10,ES_RUNTIME_JAVA=java8,nodes=virtual&&linux/226/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+periodic/2514/console
reproduction line (does not reproduce locally), failed once before on August 3 on the ccr branhc in CI.
Relevant logs:
The text was updated successfully, but these errors were encountered: