Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: YAML test missing warning about delimited_payload_filter in 6.x #31422

Closed
markharwood opened this issue Jun 19, 2018 · 7 comments
Closed

CI: YAML test missing warning about delimited_payload_filter in 6.x #31422

markharwood opened this issue Jun 19, 2018 · 7 comments
Assignees
@cbuescher
Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@markharwood
Copy link
Contributor

Latest failure https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+intake/1931/console

08:35:19   1> [2018-06-19T04:35:15,429][INFO ][o.e.a.c.CommonAnalysisClientYamlTestSuiteIT] [test {yaml=analysis-common/40_token_filters/delimited_payload_filter}]: after test
08:35:19   2> REPRODUCE WITH: ./gradlew :modules:analysis-common:integTestRunner -Dtests.seed=E933B1D4E0ED6F76 -Dtests.class=org.elasticsearch.analysis.common.CommonAnalysisClientYamlTestSuiteIT -Dtests.method="test {yaml=analysis-common/40_token_filters/delimited_payload_filter}" -Dtests.security.manager=true -Dtests.locale=sr-Latn-ME -Dtests.timezone=America/Caracas
08:35:19 FAILURE 0.14s | CommonAnalysisClientYamlTestSuiteIT.test {yaml=analysis-common/40_token_filters/delimited_payload_filter} <<< FAILURES!
08:35:19    > Throwable #1: java.lang.AssertionError: Failure at [analysis-common/40_token_filters:1035]: did not get expected warning header [
08:35:19    > 	Deprecated [delimited_payload_filter] used, replaced by [delimited_payload]
08:35:19    > ]
08:35:19    > 	at __randomizedtesting.SeedInfo.seed([E933B1D4E0ED6F76:61678E0E4E11028E]:0)
08:35:19    > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:381)
08:35:19    > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:358)
08:35:19    > 	at java.lang.Thread.run(Thread.java:748)
08:35:19    > Caused by: java.lang.AssertionError: did not get expected warning header [
08:35:19    > 	Deprecated [delimited_payload_filter] used, replaced by [delimited_payload]
08:35:19    > ]
08:35:19    > 	at org.elasticsearch.test.rest.yaml.section.DoSection.checkWarningHeaders(DoSection.java:321)
08:35:19    > 	at org.elasticsearch.test.rest.yaml.section.DoSection.execute(DoSection.java:256)
08:35:19    > 	at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:374)
08:35:19    > 	... 37 more
@markharwood markharwood added :Search Relevance/Analysis How text is split into tokens >test-failure Triaged test failures from CI labels Jun 19, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@cbuescher
Copy link
Member

This reproduces for me locally on 6.x, not running it into it on master (I think the failing test is only on 6.x).
I will disable the test for now.

cbuescher pushed a commit that referenced this issue Jun 19, 2018
Increasing skip version for failing test on 6.x
e2e59a8 
Relates to #31422
@cbuescher
Copy link
Member

I increased the skip version on the failing test on 6.x to unblock the intake build with e2e59a8.

@cbuescher
Copy link
Member

I have a hunch that "Use system context for cluster state update tasks (#31241) (commit: 78869eb)" changed something about the deprecation headers but haven't found the exact problem yet.

@cbuescher
Copy link
Member

Found the problematic commit, its 78869eb on the 6.x branch (which is the backport of #31241). When reverting it the tests pass. I think its only not failing on master because the particular test for deprecation warning headers is missing there (because the specific filter in question was removed on master). However I think this might effect deprecation warning headers in general. Digging...

cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Jun 19, 2018
Preserve response headers in MasterService#submitStateUpdateTasks
8f53081 
An integration test was expecting deprecation warnings in the rest
response headers which were missing suddenly after some change in MasterService
which had unexpected side effects. This change fixes this by preserving the
response headers of the thread context.

Closes elastic#31422
@cbuescher cbuescher mentioned this issue Jun 19, 2018
Closed
@cbuescher
Copy link
Member

@markharwood turns out my analysis was right but @ywelsch already has a PR open that seems to adress this in #31241.

@cbuescher
Copy link
Member

Since #31421 was merged to 6.x I reverted the change in the skip versions from before in 6a9db43.

@javanna javanna added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbuescher cbuescher

Labels
:Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markharwood @javanna @cbuescher @elasticmachine