Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6x Documentation is Missing an important section on Multi Level Parent Child Mappings #27336

Closed
dougnelas opened this issue Nov 9, 2017 · 4 comments
Labels
>docs General docs changes

Comments

@dougnelas
Copy link

The 6.0 and 6.x documentation is missing an important part of the parent-child support regarding the join datatype.

https://www.elastic.co/guide/en/elasticsearch/reference/current/parent-join.html#_multiple_levels_of_parent_join

In 5.6 this is documented that the parent child join type supports multiple levels of parent-child. This section is missing from the 6.x documentation which at first lead me to believe being able to map grandchild relationships would not be supported.

https://www.elastic.co/guide/en/elasticsearch/reference/6.0/parent-join.html#_multiple_children_per_parent

Comparing the difference between the sections, it is pretty clear what is missing.

@dougnelas dougnelas added the >docs General docs changes label Nov 9, 2017
@jimczi
Copy link
Contributor

jimczi commented Nov 10, 2017

@dougnelas this is intended. We don't want to document this anymore even though this is still supported internally. Running a query with a single level is already costly so more than one level should be avoided. Furthermore we don't have ideas to improve the situation so we want to slowly move away from this functionality and removing the documentation is a step toward this.

@jimczi jimczi closed this as completed Nov 10, 2017
@thomoco
Copy link

thomoco commented Nov 10, 2017

Hi @jimczi - the join type looks like very useful functionality in 6.x. For our users, having multiple levels of parent-child capability is really a critical functionality need. Yes, we all acknowledge that there are performance implications of this, but performance considerations are a cost-benefit decision. It's very important that we allow users to have this flexibility. Even with multiple tiers of parent-child functionality, Elasticsearch is still far faster than most other products at performing these operations. I'd ask you to please reconsider documenting this - we have active users using a data model requiring multiple levels of parent-child relationships. Thanks - cc: @eskibars for visibility

@thomoco thomoco reopened this Nov 10, 2017
@clintongormley
Copy link
Contributor

@jimczi I had a conversation with @colings86 about this the other day. I think we need to leave the documentation in there, but add a warning about performance and explain that trying to replicate a relational model with multiple level hierarchies is not the correct way to model your data in ES.

jimczi added a commit to jimczi/elasticsearch that referenced this issue Nov 15, 2017
…ent-join

This section was removed to hide this ability to new users.
This change restores the section and adds a warning regarding the expected performance.

Closes elastic#27336
@jimczi
Copy link
Contributor

jimczi commented Nov 15, 2017

Fair enough. I opened #27392 to restore the section with a big warning ;)

jimczi added a commit that referenced this issue Nov 16, 2017
…ent-join (#27392)

This section was removed to hide this ability to new users.
This change restores the section and adds a warning regarding the expected performance.

Closes #27336
jimczi added a commit that referenced this issue Nov 16, 2017
…ent-join (#27392)

This section was removed to hide this ability to new users.
This change restores the section and adds a warning regarding the expected performance.

Closes #27336
jimczi added a commit that referenced this issue Nov 16, 2017
…ent-join (#27392)

This section was removed to hide this ability to new users.
This change restores the section and adds a warning regarding the expected performance.

Closes #27336
jimczi added a commit that referenced this issue Nov 16, 2017
…ent-join (#27392)

This section was removed to hide this ability to new users.
This change restores the section and adds a warning regarding the expected performance.

Closes #27336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

No branches or pull requests

4 participants