Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow custom analyzers to have the same names as built-in analyzers #22263

Open
clintongormley opened this issue Dec 19, 2016 · 6 comments · May be fixed by #43252
Open

Do not allow custom analyzers to have the same names as built-in analyzers #22263

clintongormley opened this issue Dec 19, 2016 · 6 comments · May be fixed by #43252
Assignees
@mayya-sharipova
Labels
>breaking :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch

Comments

@clintongormley
Copy link
Contributor

It is confusing when custom analyzers (or tokenizers, token filters, or char filters) have the same names as built in analyzers etc. eg see #22262

We should disallow this.
@clintongormley clintongormley mentioned this issue Dec 19, 2016
Closed
makeyang added a commit to makeyang/elasticsearch that referenced this issue Dec 26, 2016
@makeyang
fix bug: elastic#22263
416e032
@makeyang makeyang mentioned this issue Dec 26, 2016
Closed
@makeyang
Copy link
Contributor

@clintongormley I pull a request for this issue: #22349. can you help to review it? thanks

@jpountz
Copy link
Contributor

jpountz commented Dec 27, 2016 •
edited
Loading

I like the idea, one minor concern I have is that it means every time we add a new built-in analyzer, we might break an existing index?

@makeyang
Copy link
Contributor

@jpountz how about make build-in staff starts with underscore and don't allow users define these staff starts with underscore?

@clintongormley
Copy link
Contributor Author

Is this something we can check on index create only?

@romseygeek
Copy link
Contributor

cc @elastic/es-search-aggs

@mayya-sharipova mayya-sharipova self-assigned this Jun 13, 2019
@mayya-sharipova mayya-sharipova removed the help wanted adoptme label Jun 13, 2019
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this issue Jun 14, 2019
@mayya-sharipova
Custom analysis can't have same names as built-in
9f04676 
Do not allow custom analysis components to have the same names as
built-in components

Closes elastic#22263
@mayya-sharipova mayya-sharipova linked a pull request Jun 14, 2019 that will close this issue
Open
@markharwood markharwood mentioned this issue Mar 31, 2020
Merged
@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
fixmebot bot referenced this issue in VectorXz/elasticsearch Apr 22, 2021
@VectorXz
Create TestFixMe.md
a9fae03
fixmebot bot referenced this issue in VectorXz/elasticsearch May 28, 2021
@VectorXz
Create Helloworld.md
1398a04
fixmebot bot referenced this issue in VectorXz/elasticsearch Aug 4, 2021
@VectorXz
Update Helloworld.md
f68abab
@thomaslow thomaslow mentioned this issue Jul 10, 2024
Closed
@javanna javanna added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayya-sharipova mayya-sharipova

Labels
>breaking :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom analysis can't have same names as built-in mayya-sharipova/elasticsearch
8 participants
@clintongormley @rjernst @jpountz @javanna @romseygeek @mayya-sharipova @makeyang @elasticsearchmachine