Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glossary should contain query and filter #16891

Closed
nik9000 opened this issue Mar 1, 2016 · 5 comments
Closed

Glossary should contain query and filter #16891

nik9000 opened this issue Mar 1, 2016 · 5 comments
Labels
>docs General docs changes good first issue low hanging fruit :Search/Search Search-related issues that do not fall into other categories

Comments

@nik9000
Copy link
Member

nik9000 commented Mar 1, 2016

The glossary should contain the terms query and filter. Both of these are used extensively in the documentation and folks who wander to the glossary aren't going to know the difference. This page in the guide is helpful but I get the sense people don't always find their way there.
@nik9000 nik9000 added the >docs General docs changes label Mar 1, 2016
@manbo-park manbo-park mentioned this issue Aug 24, 2017
Closed
@debadair debadair added the good first issue low hanging fruit label Mar 17, 2018
refactormyself added a commit to refactormyself/elasticsearch that referenced this issue Mar 17, 2018
@refactormyself
Glossary update, Closes Issue elastic#16891
9d28ba1 
Terms "Filter" and "Query" were added as described here https://www.elastic.co/guide/en/elasticsearch/guide/current/_queries_and_filters.html
@refactormyself
Copy link
Contributor

I just submitted a PR #29127 for this Issue, sorry I just discover there another PR #26353. I hope it okay. Sorry still learning ;(

@jasontedor
Copy link
Member

@refactormyself The PR (#26353) that you reference was never merged. If you want to reopen yours, someone will review it.

@jasontedor jasontedor added the :Search/Search Search-related issues that do not fall into other categories label Mar 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@refactormyself
Copy link
Contributor

PR #29127 now openend

@cbuescher
Copy link
Member

Closed by #29127, thanks @refactormyself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>docs General docs changes good first issue low hanging fruit :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nik9000 @debadair @jasontedor @cbuescher @elasticmachine @refactormyself