Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate LazyRolloverDuringDisruptionIT away from long gc disruption #115045

Closed
rjernst opened this issue Oct 17, 2024 · 1 comment · Fixed by #115075
Closed

Migrate LazyRolloverDuringDisruptionIT away from long gc disruption #115045

rjernst opened this issue Oct 17, 2024 · 1 comment · Fixed by #115075
Assignees
@gmarouli
Labels
:Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests

Comments

@rjernst
Copy link
Member

rjernst commented Oct 17, 2024

LongGCDisruption is going away because it relies on Thread.resume, which is removed in JDK 23. One test which relies on this disruption scheme is LazyRolloverDuringDisruptionIT. This test should be adjusted to use a different mechanism to block the master service thread.
@rjernst rjernst added :Data Management/Data streams Data streams and their lifecycles >test Issues or PRs that are addressing/adding tests labels Oct 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Oct 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gmarouli gmarouli mentioned this issue Oct 18, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue Oct 18, 2024
@gmarouli
Replace IntermittentLongGCDisruption with blocking cluster state upda…
5dec36e 
…tes (#115075)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it. 

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: #115045

The backport will close:
#112634
gmarouli added a commit to gmarouli/elasticsearch that referenced this issue Oct 18, 2024
@gmarouli
Replace IntermittentLongGCDisruption with blocking cluster state upda…
c297f9f 
…tes (elastic#115075)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it. 

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: elastic#115045

The backport will close:
elastic#112634
gmarouli added a commit to gmarouli/elasticsearch that referenced this issue Oct 18, 2024
@gmarouli
Replace IntermittentLongGCDisruption with blocking cluster state upda…
cf93aeb 
…tes (elastic#115075)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it. 

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: elastic#115045

The backport will close:
elastic#112634
elasticsearchmachine pushed a commit that referenced this issue Oct 18, 2024
@gmarouli
[8.16] Replace IntermittentLongGCDisruption with blocking cluster sta…
83d1dee 
…te updates (#115075) (#115085)

* Replace IntermittentLongGCDisruption with blocking cluster state updates (#115075)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it. 

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: #115045

The backport will close:
#112634

* Unmute LazyRolloverDuringDisruptionIT
elasticsearchmachine pushed a commit that referenced this issue Oct 21, 2024
@gmarouli @elasticmachine
Replace IntermittentLongGCDisruption with blocking cluster state upda…
3b2cfae 
…tes (#115075) (#115086)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it. 

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: #115045

The backport will close:
#112634

Co-authored-by: Elastic Machine <[email protected]>
gmarouli added a commit to gmarouli/elasticsearch that referenced this issue Oct 24, 2024
@gmarouli
Replace IntermittentLongGCDisruption with blocking cluster state upda…
fb659b9 
…tes (elastic#115075)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it.

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: elastic#115045

The backport will close:
elastic#112634

(cherry picked from commit 5dec36e)

# Conflicts:
#	modules/data-streams/src/internalClusterTest/java/org/elasticsearch/datastreams/LazyRolloverDuringDisruptionIT.java
elasticsearchmachine pushed a commit that referenced this issue Oct 24, 2024
@gmarouli
Replace IntermittentLongGCDisruption with blocking cluster state upda…
25ebdf4 
…tes (#115075) (#115580)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it.

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: #115045

The backport will close:
#112634

(cherry picked from commit 5dec36e)

# Conflicts:
#	modules/data-streams/src/internalClusterTest/java/org/elasticsearch/datastreams/LazyRolloverDuringDisruptionIT.java
georgewallace pushed a commit to georgewallace/elasticsearch that referenced this issue Oct 25, 2024
@gmarouli @georgewallace
Replace IntermittentLongGCDisruption with blocking cluster state upda…
5fe56b2 
…tes (elastic#115075)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it. 

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: elastic#115045

The backport will close:
elastic#112634
jfreden pushed a commit to jfreden/elasticsearch that referenced this issue Nov 4, 2024
@gmarouli @jfreden
Replace IntermittentLongGCDisruption with blocking cluster state upda…
b02f6c5 
…tes (elastic#115075)

In JDK 23 `Thread.resume` has been removed this means that we cannot use
`IntermittentLongGCDisruption` that depends on it. 

We simulate the master node disruption with a `CyclicBarrier` that
blocks cluster state updates.

Closes: elastic#115045

The backport will close:
elastic#112634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmarouli gmarouli

Labels
:Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace IntermittentLongGCDisruption with blocking cluster state updates gmarouli/elasticsearch
3 participants
@rjernst @gmarouli @elasticsearchmachine