Skip to content

Commit

Permalink
Emit deprecation warning for variable size predictor
Browse files Browse the repository at this point in the history
With this commit we mark the following settings as deprecated:

* http.netty.receive_predictor_min
* http.netty.receive_predictor_max

The settings infrastructure then emits a deprecation warning upon startup if
these settings are configured.

Relates #26165
  • Loading branch information
danielmitterdorfer committed Oct 10, 2017
1 parent f39a50b commit e48d747
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -138,14 +138,16 @@ public class Netty4HttpServerTransport extends AbstractLifecycleComponent implem
*/
@Deprecated
public static final Setting<ByteSizeValue> SETTING_HTTP_NETTY_RECEIVE_PREDICTOR_MIN =
byteSizeSetting("http.netty.receive_predictor_min", SETTING_HTTP_NETTY_RECEIVE_PREDICTOR_SIZE, Property.NodeScope);
byteSizeSetting("http.netty.receive_predictor_min", SETTING_HTTP_NETTY_RECEIVE_PREDICTOR_SIZE,
Property.NodeScope, Property.Deprecated);

/**
* @deprecated This (undocumented) setting is deprecated to reduce complexity and is removed in 7.0. See #26165 for details.
*/
@Deprecated
public static final Setting<ByteSizeValue> SETTING_HTTP_NETTY_RECEIVE_PREDICTOR_MAX =
byteSizeSetting("http.netty.receive_predictor_max", SETTING_HTTP_NETTY_RECEIVE_PREDICTOR_SIZE, Property.NodeScope);
byteSizeSetting("http.netty.receive_predictor_max", SETTING_HTTP_NETTY_RECEIVE_PREDICTOR_SIZE,
Property.NodeScope, Property.Deprecated);


protected final NetworkService networkService;
Expand Down

0 comments on commit e48d747

Please sign in to comment.