-
Notifications
You must be signed in to change notification settings - Fork 25k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Forbid dedicated frozen nodes w/ unfrozen indices (#71395)
We only want the shards of frozen (i.e. partially-cached searchable snapshot backed) indices to be allocated to dedicated frozen nodes but today we only weakly achieve this thanks to the data tier allocation rules. This commit introduces an allocation decider that directly enforces this constraint.
- Loading branch information
1 parent
aaacb79
commit adaf372
Showing
3 changed files
with
140 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
...ch/xpack/searchablesnapshots/allocation/decider/DedicatedFrozenNodeAllocationDecider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| package org.elasticsearch.xpack.searchablesnapshots.allocation.decider; | ||
|
|
||
| import org.elasticsearch.cluster.metadata.IndexMetadata; | ||
| import org.elasticsearch.cluster.node.DiscoveryNode; | ||
| import org.elasticsearch.cluster.node.DiscoveryNodeRole; | ||
| import org.elasticsearch.cluster.routing.RoutingNode; | ||
| import org.elasticsearch.cluster.routing.ShardRouting; | ||
| import org.elasticsearch.cluster.routing.allocation.RoutingAllocation; | ||
| import org.elasticsearch.cluster.routing.allocation.decider.AllocationDecider; | ||
| import org.elasticsearch.cluster.routing.allocation.decider.Decision; | ||
| import org.elasticsearch.common.settings.Settings; | ||
| import org.elasticsearch.xpack.searchablesnapshots.SearchableSnapshotsConstants; | ||
|
|
||
| import static org.elasticsearch.cluster.node.DiscoveryNodeRole.DATA_FROZEN_NODE_ROLE; | ||
| import static org.elasticsearch.xpack.searchablesnapshots.SearchableSnapshotsConstants.SNAPSHOT_PARTIAL_SETTING; | ||
|
|
||
| public class DedicatedFrozenNodeAllocationDecider extends AllocationDecider { | ||
|
|
||
| private static final String NAME = "dedicated_frozen_node"; | ||
|
|
||
| private static final Decision YES_NOT_DEDICATED_FROZEN_NODE = Decision.single( | ||
| Decision.Type.YES, | ||
| NAME, | ||
| "this node's data roles are not exactly [" + DATA_FROZEN_NODE_ROLE.roleName() + "] so it is not a dedicated frozen node" | ||
| ); | ||
|
|
||
| private static final Decision YES_IS_PARTIAL_SEARCHABLE_SNAPSHOT = Decision.single( | ||
| Decision.Type.YES, | ||
| NAME, | ||
| "this index is a frozen searchable snapshot so it can be assigned to this dedicated frozen node" | ||
| ); | ||
|
|
||
| private static final Decision NO = Decision.single( | ||
| Decision.Type.NO, | ||
| NAME, | ||
| "this node's data roles are exactly [" | ||
| + DATA_FROZEN_NODE_ROLE.roleName() | ||
| + "] so it may only hold shards from frozen searchable snapshots, but this index is not a frozen searchable snapshot" | ||
| ); | ||
|
|
||
| @Override | ||
| public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, RoutingAllocation allocation) { | ||
| return canAllocateToNode(allocation.metadata().getIndexSafe(shardRouting.index()), node.node()); | ||
| } | ||
|
|
||
| @Override | ||
| public Decision canRemain(ShardRouting shardRouting, RoutingNode node, RoutingAllocation allocation) { | ||
| return canAllocateToNode(allocation.metadata().getIndexSafe(shardRouting.index()), node.node()); | ||
| } | ||
|
|
||
| @Override | ||
| public Decision canAllocate(IndexMetadata indexMetadata, RoutingNode node, RoutingAllocation allocation) { | ||
| return canAllocateToNode(indexMetadata, node.node()); | ||
| } | ||
|
|
||
| @Override | ||
| public Decision shouldAutoExpandToNode(IndexMetadata indexMetadata, DiscoveryNode node, RoutingAllocation allocation) { | ||
| return canAllocateToNode(indexMetadata, node); | ||
| } | ||
|
|
||
| private Decision canAllocateToNode(IndexMetadata indexMetadata, DiscoveryNode discoveryNode) { | ||
|
|
||
| boolean hasDataFrozenRole = false; | ||
| boolean hasOtherDataRole = false; | ||
| for (DiscoveryNodeRole role : discoveryNode.getRoles()) { | ||
| if (DATA_FROZEN_NODE_ROLE.equals(role)) { | ||
| hasDataFrozenRole = true; | ||
| } else if (role.canContainData()) { | ||
| hasOtherDataRole = true; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (hasDataFrozenRole == false || hasOtherDataRole) { | ||
| return YES_NOT_DEDICATED_FROZEN_NODE; | ||
| } | ||
|
|
||
| final Settings indexSettings = indexMetadata.getSettings(); | ||
| if (SearchableSnapshotsConstants.isSearchableSnapshotStore(indexSettings) && SNAPSHOT_PARTIAL_SETTING.get(indexSettings)) { | ||
| return YES_IS_PARTIAL_SEARCHABLE_SNAPSHOT; | ||
| } | ||
|
|
||
| return NO; | ||
| } | ||
| } |