INGEST: Clean up Java8 Stream Usage (#32059) (#32485)

* GrokProcessor: Rationalize the loop over the map to save allocations and indirection * IngestDocument: Rationalize way we append to `List`
elastic · Jul 31, 2018 · 7551fbc · 7551fbc
1 parent adeec7e
commit 7551fbc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/GrokProcessor.java b/modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/GrokProcessor.java
@@ -68,8 +68,7 @@ public void execute(IngestDocument ingestDocument) throws Exception {
             throw new IllegalArgumentException("Provided Grok expressions do not match field value: [" + fieldValue + "]");
         }
 
-        matches.entrySet().stream()
-            .forEach((e) -> ingestDocument.setFieldValue(e.getKey(), e.getValue()));
+        matches.forEach(ingestDocument::setFieldValue);
 
         if (traceMatch) {
             if (matchPatterns.size() > 1) {

diff --git a/server/src/main/java/org/elasticsearch/ingest/IngestDocument.java b/server/src/main/java/org/elasticsearch/ingest/IngestDocument.java
@@ -531,8 +531,7 @@ private static List<Object> appendValues(Object maybeList, Object value) {
 
     private static void appendValues(List<Object> list, Object value) {
         if (value instanceof List) {
-            List<?> valueList = (List<?>) value;
-            valueList.stream().forEach(list::add);
+            list.addAll((List<?>) value);
         } else {
             list.add(value);
         }