Skip to content

Commit

Permalink
Remove AwaitFix HeapAttack tests in 8.11 (#103154)
Browse files Browse the repository at this point in the history
We've made some improvements in memory tracking in ESQL, but due to 
their complexity, we intentionally chose not to backport them to 8.11.
Without these enhancements, some HeapAttack tests are not ready for
8.11. I think we should remove the AwaitsFix tests and focus on 8.13
instead.

Closes #100640
  • Loading branch information
dnhatn authored Dec 7, 2023
1 parent 7de781d commit 64cf052
Showing 1 changed file with 0 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -110,21 +110,6 @@ public void testGroupOnSomeLongs() throws IOException {
assertMap(map, matchesMap().entry("columns", columns).entry("values", values));
}

/**
* This groups on 5000 columns which used to throw a {@link StackOverflowError}.
*/
public void testGroupOnManyLongs() throws IOException {
initManyLongs();
Map<?, ?> map = XContentHelper.convertToMap(
JsonXContent.jsonXContent,
EntityUtils.toString(groupOnManyLongs(5000).getEntity()),
false
);
ListMatcher columns = matchesList().item(matchesMap().entry("name", "MAX(a)").entry("type", "long"));
ListMatcher values = matchesList().item(List.of(9));
assertMap(map, matchesMap().entry("columns", columns).entry("values", values));
}

private Response groupOnManyLongs(int count) throws IOException {
logger.info("grouping on {} longs", count);
StringBuilder query = makeManyLongs(count);
Expand Down Expand Up @@ -247,12 +232,6 @@ public void testManyEval() throws IOException {
assertMap(map, matchesMap().entry("columns", columns).entry("values", hasSize(10_000)));
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100528")
public void testTooManyEval() throws IOException {
initManyLongs();
assertCircuitBreaks(() -> manyEval(1000));
}

private Response manyEval(int evalLines) throws IOException {
StringBuilder query = new StringBuilder();
query.append("{\"query\":\"FROM manylongs");
Expand Down Expand Up @@ -289,12 +268,6 @@ public void testFetchManyBigFields() throws IOException {
fetchManyBigFields(100);
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100528")
public void testFetchTooManyBigFields() throws IOException {
initManyBigFieldsIndex(500);
assertCircuitBreaks(() -> fetchManyBigFields(500));
}

/**
* Fetches documents containing 1000 fields which are {@code 1kb} each.
*/
Expand Down Expand Up @@ -345,12 +318,6 @@ public void testFetchMvLongs() throws IOException {
assertMap(map, matchesMap().entry("columns", columns));
}

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100528")
public void testFetchTooManyMvLongs() throws IOException {
initMvLongsIndex(500, 100, 1000);
assertCircuitBreaks(() -> fetchMvLongs());
}

private Response fetchMvLongs() throws IOException {
return query("{\"query\": \"FROM mv_longs\"}", "columns");
}
Expand Down

0 comments on commit 64cf052

Please sign in to comment.