use local variable

elastic · Aug 4, 2020 · 5c26a6b · 5c26a6b
1 parent cb3d4a0
commit 5c26a6b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/server/src/main/java/org/elasticsearch/ingest/TrackingResultProcessor.java b/server/src/main/java/org/elasticsearch/ingest/TrackingResultProcessor.java
@@ -36,7 +36,6 @@ public final class TrackingResultProcessor implements Processor {
     private final ConditionalProcessor conditionalProcessor;
     private final List<SimulateProcessorResult> processorResultList;
     private final boolean ignoreFailure;
-    private Tuple<String, Boolean> conditionalWithResult = null; //null = no conditional
 
     TrackingResultProcessor(boolean ignoreFailure, Processor actualProcessor, ConditionalProcessor conditionalProcessor,
                             List<SimulateProcessorResult> processorResultList) {
@@ -48,16 +47,19 @@ public final class TrackingResultProcessor implements Processor {
 
     @Override
     public void execute(IngestDocument ingestDocument, BiConsumer<IngestDocument, Exception> handler) {
-        if (conditionalProcessor != null ) {
+        Tuple<String, Boolean> conditionalWithResult;
+        if (conditionalProcessor != null) {
             if (conditionalProcessor.evaluate(ingestDocument) == false) {
                 conditionalWithResult = new Tuple<>(conditionalProcessor.getCondition(), Boolean.FALSE);
                 processorResultList.add(new SimulateProcessorResult(actualProcessor.getType(), actualProcessor.getTag(),
                     actualProcessor.getDescription(), conditionalWithResult));
                 handler.accept(ingestDocument, null);
                 return;
-            } else{
+            } else {
                 conditionalWithResult = new Tuple<>(conditionalProcessor.getCondition(), Boolean.TRUE);
             }
+        } else {
+            conditionalWithResult = null; //no condition
         }
 
         if (actualProcessor instanceof PipelineProcessor) {