-
Notifications
You must be signed in to change notification settings - Fork 25k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move creation of temporary directory to Java (#36002)
In the long run we want to move all of startup to a Java program. This will simplify our startup scripts and make maintenance of startup less dependent on the underlying platform that we run on. This commit moves the creation of the temporary directory off of system-dependent commands and onto a simple Java program.
- Loading branch information
1 parent
0916a1f
commit 4652337
Showing
4 changed files
with
71 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
...bution/tools/launchers/src/main/java/org/elasticsearch/tools/launchers/TempDirectory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Licensed to Elasticsearch under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.elasticsearch.tools.launchers; | ||
|
||
import java.io.IOException; | ||
import java.nio.file.Files; | ||
import java.nio.file.Path; | ||
import java.nio.file.Paths; | ||
import java.util.Arrays; | ||
|
||
/** | ||
* Provides a path for a temporary directory. On non-Windows OS, this will be created as a sub-directory of the default temporary directory. | ||
* Note that this causes the created temporary directory to be a private temporary directory. | ||
*/ | ||
final class TempDirectory { | ||
|
||
/** | ||
* The main entry point. The exit code is 0 if we successfully created a temporary directory as a sub-directory of the default | ||
* temporary directory and printed the resulting path to the console. | ||
* | ||
* @param args the args to the program which should be empty | ||
* @throws IOException if an I/O exception occurred while creating the temporary directory | ||
*/ | ||
public static void main(final String[] args) throws IOException { | ||
if (args.length != 0) { | ||
throw new IllegalArgumentException("expected zero arguments but was " + Arrays.toString(args)); | ||
} | ||
/* | ||
* On Windows, we avoid creating a unique temporary directory per invocation lest we pollute the temporary directory. On other | ||
* operating systems, temporary directories will be cleaned automatically via various mechanisms (e.g., systemd, or restarts). | ||
*/ | ||
final Path path; | ||
if (System.getProperty("os.name").startsWith("Windows")) { | ||
path = Paths.get(System.getProperty("java.io.tmpdir"), "elasticsearch"); | ||
Files.createDirectories(path); | ||
} else { | ||
path = Launchers.createTempDirectory("elasticsearch-"); | ||
} | ||
Launchers.outPrintln(path.toString()); | ||
} | ||
|
||
} |
for /f "tokens=* usebackq" %%a in ('%JAVA% -cp "!ES_CLASSPATH!" "org.elasticsearch.tools.launchers.TempDirectory"') do set ES_TMPDIR=%%a
#38578