test IncludeShardsStatsFlag via getShardStats(Index index) instead ge…

…tStatsByShard()
elastic · Oct 13, 2023 · 3ddf821 · 3ddf821
1 parent 9d20eda
commit 3ddf821
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/server/src/main/java/org/elasticsearch/indices/NodeIndicesStats.java b/server/src/main/java/org/elasticsearch/indices/NodeIndicesStats.java
@@ -214,11 +214,6 @@ public DenseVectorStats getDenseVectorStats() {
         return stats.getDenseVectorStats();
     }
 
-    // for testing
-    Map<Index, List<IndexShardStats>> getStatsByShard() {
-        return statsByShard;
-    }
-
     @Override
     public void writeTo(StreamOutput out) throws IOException {
         stats.writeTo(out);

diff --git a/server/src/test/java/org/elasticsearch/indices/NodeIndicesStatsTests.java b/server/src/test/java/org/elasticsearch/indices/NodeIndicesStatsTests.java
@@ -20,6 +20,7 @@
 
 import static org.hamcrest.CoreMatchers.containsString;
 import static org.hamcrest.CoreMatchers.sameInstance;
+import static org.hamcrest.Matchers.nullValue;
 import static org.hamcrest.object.HasToString.hasToString;
 
 public class NodeIndicesStatsTests extends ESTestCase {
@@ -36,11 +37,14 @@ public void testInvalidLevel() {
     }
 
     public void testIncludeShardsStatsFlag() {
+        final Index index = new Index("test", "_na_");
         final Map<Index, List<IndexShardStats>> statsByShards = new HashMap<>();
+        final List<IndexShardStats> emptyList = List.of();
+        statsByShards.put(index, emptyList);
         NodeIndicesStats stats = new NodeIndicesStats(null, Collections.emptyMap(), statsByShards, true);
-        assertThat(stats.getStatsByShard(), sameInstance(statsByShards));
+        assertThat(stats.getShardStats(index), sameInstance(emptyList));
         stats = new NodeIndicesStats(null, Collections.emptyMap(), statsByShards, false);
-        assertThat(stats.getStatsByShard(), sameInstance(Map.of()));
+        assertThat(stats.getShardStats(index), nullValue());
     }
 
 }