Skip to content

Commit

Permalink
Elasticsearch dependency should be provided and not compile
Browse files Browse the repository at this point in the history
Please change the Elasticsearch dependency to provided (and maybe testCompile) instead of compile and runtime.

Why? If you include the plugin in embedded Elasticsearch, and you exclude anything from the Elasticsearch dependency, it is undone by this dependency also including Elasticsearch. Therefore you have to tune both, when really this plugin only needs it as provided (since it runs with Elasticsearch or in Elasticsearch but never on its own).

Closes #48.
  • Loading branch information
dadoonet committed Mar 17, 2014
1 parent bbb0644 commit 3616ed6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<groupId>org.elasticsearch</groupId>
<artifactId>elasticsearch</artifactId>
<version>${elasticsearch.version}</version>
<scope>compile</scope>
<scope>provided</scope>
</dependency>

<dependency>
Expand Down

0 comments on commit 3616ed6

Please sign in to comment.