Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values for EQL allow_partial_search_results and allow_partial_sequence_results #3637

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

luigidellaquila
Copy link
Contributor

Adding description and default values for EQL allow_partial_search_results and allow_partial_sequence_results

Wait for elastic/elasticsearch#120887 before backporting

…tial_sequence_results
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
eql.search 🟢 37/37 37/37

You can validate this API yourself by using the make validate target.

@luigidellaquila
Copy link
Contributor Author

luigidellaquila commented Jan 29, 2025

Double check the backport of #3372 before merging.
It should not block it, but it touches the same spec, so there could be conflicts on the backport of this one.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin merged commit d74ecca into main Jan 29, 2025
19 of 20 checks passed
@pquentin pquentin deleted the eql/allow_partial_search_results_default branch January 29, 2025 17:23
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
…tial_sequence_results (#3637)

(cherry picked from commit d74ecca)
l-trotta added a commit that referenced this pull request Jan 31, 2025
…tial_sequence_results (#3637) (#3652)

(cherry picked from commit d74ecca)

Co-authored-by: Luigi Dell'Aquila <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
github-actions bot added a commit that referenced this pull request Jan 31, 2025
…tial_sequence_results (#3637) (#3652)

(cherry picked from commit d74ecca)

Co-authored-by: Luigi Dell'Aquila <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit a38549b)
l-trotta pushed a commit that referenced this pull request Jan 31, 2025
…tial_sequence_results (#3637) (#3652) (#3675)

(cherry picked from commit d74ecca)

Co-authored-by: Luigi Dell'Aquila <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
(cherry picked from commit a38549b)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants