[API] Avoid instantiating an array of valid params for each request, each time it is called #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estolfo
force-pushed
the
valid-params-const
branch
4 times, most recently
from
412d650 to
f9019cf
Compare
estolfo
force-pushed
the
valid-params-const
branch
from
f9019cf to
8e238d2
Compare
estolfo
force-pushed
the
valid-params-const
branch
from
8e238d2 to
5da9089
Compare
estolfo
added a commit
that referenced
this pull request
Oct 23, 2018
…each time it is called (#550) * [API] Add ParamsRegistry for non-namespaced actions * [API] Add ParamsRegistry for cat actions * [API] Add ParamsRegistry for cluster actions * [API] Add ParamsRegistry for indices actions * [API] Add ParamsRegistry for ingest actions * [API] Add ParamsRegistry for nodes actions * [API] Add ParamsRegistry for snapshot actions * [API] Add ParamsRegistry for tasks actions * [API] Fix typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a
ParamsRegistryfor each api namespace so that valid params can be looked up instead of defined as a new array every time a method is called.