Fix Compression #1478
Merged
Fix Compression #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decompress compressed responses, whether or not use_compression is set.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@picandocodigo can you please review this? |
|
At TableCheck we are using this in production by the way (with Faraday) |
|
Thanks for this contribution @johnnyshields! I'll review and merge it as soon as possible 👍 |
|
jenkins test this please |
|
Thank you very much for this contribution @johnnyshields! |
This was referenced Oct 8, 2021
an-empty-string
pushed a commit
to ActionNetwork/elasticsearch-ruby
that referenced
this pull request
Mar 8, 2023
- "compression" option should compress outbound requests. - Decompress compressed responses, whether or not use_compression is set. Properly set header on gzipped request body Perform compression inside HTTP adapters Explicitly require zlib library Content-Encoding is set in the HTTP adapters, so we don't need it in the apply_headers method Add specs for curb, faraday, and manticore Update curb_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
The
compressionoption is badly broken.This is from the documents:
In fact, much of this is not working as per spec.
Whether to compress requests.--> NOT WORKING The option does not currently compress requests, it merely sets theAccept-Encodingheader which only affects responses.Responses are automatically inflated if they are compressed.--> NOT WORKING. Responses are currently not inflated unless thecompressionoption is explicitly set. This means that ifcompressionis not set, any compressed responses will be unreadable (i.e. cause an error.)The Fix
compressionoption should compress outbound requests by setting theContent-Encodingheader.Content-Encodingheader is set.)compressionis set.