Skip to content

Commit

Permalink
Adds base64 dependency
Browse files Browse the repository at this point in the history
base64 was added to the gemspec, since starting in Ruby 3.4.0, base64 will no longer be part of the
default gems and will no longer be in the standard library.

base64 is used forAPI key and Cloud ID. The dependency used to be declared in transport, but it's
not needed there since the implementation using it is in this codebase.
  • Loading branch information
picandocodigo committed Jan 25, 2024
1 parent 6acc5ac commit c6779ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion elasticsearch/elasticsearch.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ Gem::Specification.new do |s|
s.required_ruby_version = '>= 2.5'

s.add_dependency 'elastic-transport', '~> 8.3'

s.add_dependency 'elasticsearch-api', '8.13.0'
s.add_dependency 'base64'

s.add_development_dependency 'bundler'
s.add_development_dependency 'byebug' unless defined?(JRUBY_VERSION) || defined?(Rubinius)
Expand Down
1 change: 1 addition & 0 deletions elasticsearch/lib/elasticsearch.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
require 'elasticsearch/version'
require 'elastic/transport'
require 'elasticsearch/api'
require 'base64'

module Elasticsearch
NOT_ELASTICSEARCH_WARNING = 'The client noticed that the server is not Elasticsearch and we do not support this unknown product.'.freeze
Expand Down

0 comments on commit c6779ec

Please sign in to comment.