Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readthedocs content to the guide #2769

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

miguelgrinberg
Copy link
Contributor

@miguelgrinberg miguelgrinberg commented Jan 27, 2025

This change adds content only available in the readthedocs documentation to the Python client guide hosted on elastic.co.

  • new section on using asyncio with the Python Elasticsearch client
  • additional examples hosted on the elasticsearch-labs repo as notebooks
  • minor additions and improvements to the getting started page

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@miguelgrinberg miguelgrinberg force-pushed the rtd-docs-merge branch 2 times, most recently from 647753a to a6de800 Compare January 27, 2025 17:14
@miguelgrinberg miguelgrinberg marked this pull request as ready for review January 27, 2025 17:15
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work,thank you! Can we easily add a sample code snippet to the index page?

docs/guide/async.asciidoc Outdated Show resolved Hide resolved
docs/guide/async.asciidoc Show resolved Hide resolved
docs/guide/async.asciidoc Show resolved Hide resolved
docs/guide/async.asciidoc Show resolved Hide resolved
docs/guide/async.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg merged commit 03033cc into elastic:main Jan 28, 2025
12 checks passed
@miguelgrinberg miguelgrinberg deleted the rtd-docs-merge branch January 28, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants