Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEST support for EQL Search API #5658

Merged
merged 21 commits into from
May 4, 2021
Merged

Add NEST support for EQL Search API #5658

merged 21 commits into from
May 4, 2021

Conversation

stevejgordon
Copy link
Contributor

Adds support for searching using EQL from the NEST client.

Contributes to #5584

@Mpdreamz - As this is a bit meaty, would you mind casting an eye over it? I opted not to create an interface for EqlSearchResponse and the types used for Event and Sequence which differs a little from the existing search code elsewhere.

@stevejgordon
Copy link
Contributor Author

Gonna assume the license header failure is a line endings thing. Will review on Tuesday.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the inferfaces for Search are there to facilitate mocking. This is the only API we support mocking to an extend so no interfaces for the other responses makes sense here too.

@stevejgordon stevejgordon merged commit f96a6f9 into 7.13 May 4, 2021
@stevejgordon stevejgordon deleted the feature/eql-search branch May 4, 2021 06:03
github-actions bot pushed a commit that referenced this pull request May 4, 2021
* Add request and response classes

* Code gen for EQL search

* Add initial request properties

* Initial response for testing

* Un-skip EQL APIs from high-level code gen

* Generate EQL code

* Work on request and response types

* Add event type for EQL

* Update NEST code gen with license headers

* Update request/response

* Adding initial test

* Support generic searches

* Fixing URLs and adding URL tests

* Add descriptor methods

* Add sequence tests

* Remove interfaces and update comments.

* Remove redundant code in TimeSeriesCluster

* Cleanup namespaces

* Update license headers

* Update headers

* Remove UTF-8 BOM
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

The backport to master failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5658-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 f96a6f94f82d81d954263df8e290c8b00ffefab1
# Push it to GitHub
git push --set-upstream origin backport-5658-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-master

Then, create a pull request where the base branch is master and the compare/head branch is backport-5658-to-master.

stevejgordon added a commit that referenced this pull request May 4, 2021
* Add request and response classes

* Code gen for EQL search

* Add initial request properties

* Initial response for testing

* Un-skip EQL APIs from high-level code gen

* Generate EQL code

* Work on request and response types

* Add event type for EQL

* Update NEST code gen with license headers

* Update request/response

* Adding initial test

* Support generic searches

* Fixing URLs and adding URL tests

* Add descriptor methods

* Add sequence tests

* Remove interfaces and update comments.

* Remove redundant code in TimeSeriesCluster

* Cleanup namespaces

* Update license headers

* Update headers

* Remove UTF-8 BOM

(cherry picked from commit f96a6f9)
stevejgordon added a commit that referenced this pull request May 4, 2021
* Add request and response classes

* Code gen for EQL search

* Add initial request properties

* Initial response for testing

* Un-skip EQL APIs from high-level code gen

* Generate EQL code

* Work on request and response types

* Add event type for EQL

* Update NEST code gen with license headers

* Update request/response

* Adding initial test

* Support generic searches

* Fixing URLs and adding URL tests

* Add descriptor methods

* Add sequence tests

* Remove interfaces and update comments.

* Remove redundant code in TimeSeriesCluster

* Cleanup namespaces

* Update license headers

* Update headers

* Remove UTF-8 BOM

Co-authored-by: Steve Gordon <[email protected]>
stevejgordon added a commit that referenced this pull request May 4, 2021
* Add NEST support for EQL Search API (#5658)

* Add request and response classes

* Code gen for EQL search

* Add initial request properties

* Initial response for testing

* Un-skip EQL APIs from high-level code gen

* Generate EQL code

* Work on request and response types

* Add event type for EQL

* Update NEST code gen with license headers

* Update request/response

* Adding initial test

* Support generic searches

* Fixing URLs and adding URL tests

* Add descriptor methods

* Add sequence tests

* Remove interfaces and update comments.

* Remove redundant code in TimeSeriesCluster

* Cleanup namespaces

* Update license headers

* Update headers

* Remove UTF-8 BOM

(cherry picked from commit f96a6f9)

* Update code-gen

* Update namespaces

* Update license header for descriptors

* Update unrelated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants