Support clear api key cache #5147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
requested changes
Dec 4, 2020
Excellent catch @stevejgordon 🔍 👍 |
|
@Mpdreamz I think I've patched this correctly and now per the updated tests, we can support optional IDs. |
Mpdreamz
approved these changes
Dec 4, 2020
Mpdreamz
requested changes
Dec 7, 2020
src/ApiGenerator/RestSpecification/_Patches/security.clear_api_key_cache.patch.json
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Dec 7, 2020
* Support clear API key cache * Patched to support optional ids
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-master master
# Navigate to the new working tree
cd .worktrees/backport-master
# Create a new branch
git switch --create backport-5147-to-master
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 e607d3126d05ec862c4d2a9de37bfcaecc05a249
# Push it to GitHub
git push --set-upstream origin backport-5147-to-master
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-masterThen, create a pull request where the |
stevejgordon
added a commit
that referenced
this pull request
Dec 7, 2020
* Support clear API key cache * Patched to support optional ids
stevejgordon
added a commit
that referenced
this pull request
Dec 8, 2020
* Support clear API key cache * Patched to support optional ids Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Dec 8, 2020
* Support clear API key cache (#5147) * Support clear API key cache * Patched to support optional ids
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated
UrlPartto support the use of theIdstype which seemed appropriate.One query for review... The docs for this API suggest that the ids in the path can be empty to clear cache for all keys. The generated code requires the presence of an ID part and I'm not sure if this is okay or how best to address it?
Contributes to #5096