Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Voting Config Exclusions APIs #4738

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 4, 2020

Relates: #4718, elastic/elasticsearch#55760

This commit adds the voting config exclusions APIs to the high level client.
Custom response builder types are required because the APIs return
\n as the response, which the client will attempt to deserialize to a
response object.

Relates: #4718, elastic/elasticsearch#55760

This commit adds the voting config exclusions APIs to the high level client.
Custom response builder types are required because the APIs return
\n as the response, which the client will attempt to deserialize to a
response object.
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz
Copy link
Member

Mpdreamz commented Jun 9, 2020

Do we have an issue on the elasticsearch repos tracking the empty new line?

@russcam
Copy link
Contributor Author

russcam commented Jun 9, 2020

Yep, here's the Elasticsearch issue: elastic/elasticsearch#57639

@russcam russcam merged commit e007934 into master Jun 10, 2020
@russcam russcam deleted the feature/voting-config-exclusions branch June 10, 2020 03:18
github-actions bot pushed a commit that referenced this pull request Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760

This commit adds the voting config exclusions APIs to the high level client.
Custom response builder types are required because the APIs return
\n as the response, which the client will attempt to deserialize to a
response object.
github-actions bot pushed a commit that referenced this pull request Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760

This commit adds the voting config exclusions APIs to the high level client.
Custom response builder types are required because the APIs return
\n as the response, which the client will attempt to deserialize to a
response object.
russcam added a commit that referenced this pull request Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760

This commit adds the voting config exclusions APIs to the high level client.
Custom response builder types are required because the APIs return
\n as the response, which the client will attempt to deserialize to a
response object.

Co-authored-by: Russ Cam <[email protected]>
russcam added a commit that referenced this pull request Jun 10, 2020
Relates: #4718, elastic/elasticsearch#55760

This commit adds the voting config exclusions APIs to the high level client.
Custom response builder types are required because the APIs return
\n as the response, which the client will attempt to deserialize to a
response object.

Co-authored-by: Russ Cam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants