Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for bounds in geohash_grid aggregation #4403

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Add support for bounds in geohash_grid aggregation #4403

merged 1 commit into from
Feb 21, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Feb 20, 2020

Relates: #4341, elastic/elasticsearch#50002

This commit adds support for supplying bounds on a geohash_grid
aggregation, similar to how bounds are supplied on
geo_bounding_box query.

@russcam
Add support for bounds in geohash_grid aggregation
126d709 
Relates: #4341, elastic/elasticsearch#50002

This commit adds support for supplying bounds on a geohash_grid
aggregation, similar to how bounds are supplied on
geo_bounding_box query.
@russcam russcam mentioned this pull request Feb 20, 2020
Closed
@Mpdreamz
Copy link
Member

Unit test failure is unrelated

[xUnit.net 00:00:02.9411802]     Tests.Reproduce.TimeSpanSerialization.SerializeTimeSpansAsTicksAndStrings [FAIL]
  X Tests.Reproduce.TimeSpanSerialization.SerializeTimeSpansAsTicksAndStrings [152ms]
  Error Message:
   Expected 104d, 10h, 38m and 32s, but found 10d, 10h, 38m and 32s.
  Stack Trace:
     at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
   at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
   at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)
   at FluentAssertions.Primitives.SimpleTimeSpanAssertions.Be(TimeSpan expected, String because, Object[] becauseArgs)
   at Tests.Reproduce.TimeSpanSerialization.SerializeTimeSpansAsTicksAndStrings() in /home/vsts/work/1/s/tests/Tests.Reproduce/TimeSpanSerialization.cs:line 30
[xUnit.net 00:00:03.2945958]     Tests.Reproduce.GithubPR3815.CanDeserializeNestedError [SKIP]
  ! Tests.Reproduce.GithubPR3815.CanDeserializeNestedError [1ms]

@Mpdreamz Mpdreamz merged commit 8ed67e3 into 7.x Feb 21, 2020
@Mpdreamz Mpdreamz deleted the feature/7x/geohash-grid-bounds branch February 21, 2020 09:27
github-actions bot pushed a commit that referenced this pull request Feb 21, 2020
@russcam @github-actions
Add support for bounds in geohash_grid aggregation (#4403)
72f590a 
Relates: #4341, elastic/elasticsearch#50002

This commit adds support for supplying bounds on a geohash_grid
aggregation, similar to how bounds are supplied on
geo_bounding_box query.
@github-actions github-actions bot mentioned this pull request Feb 21, 2020
Merged
@Mpdreamz
Copy link
Member

Opened #4423 to track the unit test failure

russcam added a commit that referenced this pull request Feb 23, 2020
@russcam
Add support for bounds in geohash_grid aggregation (#4403)
501d90b 
Relates: #4341, elastic/elasticsearch#50002

This commit adds support for supplying bounds on a geohash_grid
aggregation, similar to how bounds are supplied on
geo_bounding_box query.

(cherry picked from commit 8ed67e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russcam @Mpdreamz