Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement shape property type mapping. #4154

Merged
merged 17 commits into from
Oct 18, 2019
Merged

Implement shape property type mapping. #4154

merged 17 commits into from
Oct 18, 2019

Conversation

codebrain
Copy link
Contributor

This was referenced Oct 17, 2019
Closed
Merged
Mpdreamz and others added 8 commits October 17, 2019 12:09
@Mpdreamz
PinnedQuery tests should not run <7.4.0
21baa66
@codebrain @Mpdreamz
Implement disable_chucked_encoding s3 repository setting. (#4146)
1335806
@codebrain @Mpdreamz
Implement snapshot repository cleanup (#4145)
4e94249 
* Implement snapshot repository cleanup

* add TODO on CleanUpRepositoryApiTests
@codebrain @Mpdreamz
Implement vector usage (#4151)
31c0862
@Mpdreamz
update to latest greatest abstractions that can figure out 7.5.0 is n…
c900e45 
…ot a released version but a build candidate

(cherry picked from commit 5ab3590)
@Mpdreamz
update to latest greatest abstractions that can figure out 7.5.0 is n…
426087c 
…ot a released version but a build candidate and fixed a small bug in canary version calculation

(cherry picked from commit ec5eb51)
@Mpdreamz
ElasticsearchVersion on Tests.Configuration is now ElasticVersion not…
a247af8 
… string
@Mpdreamz
slm in progress test sometimes does not return in_progress information
06517e3
Mpdreamz
Mpdreamz approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to implement some SkipVersions. might be worth rebasing against 7.x as several test fixes went into there today

src/Tests/Tests/Indices/MappingManagement/PutMapping/PutMappingApiTest.cs Show resolved Hide resolved
src/Tests/Tests/Mapping/Types/Specialized/Shape/ShapePropertyTests.cs Show resolved Hide resolved
@codebrain codebrain merged commit 2979300 into 7.x Oct 18, 2019
codebrain added a commit that referenced this pull request Oct 18, 2019
@codebrain
Implement shape property type mapping and shape queries. (#4154) (#4155)
27f44ed
Mpdreamz added a commit that referenced this pull request Oct 21, 2019
@Mpdreamz
fix #4154 should be more version independent
1c4c418
Mpdreamz added a commit that referenced this pull request Oct 21, 2019
@Mpdreamz
7.x integration tests fixes (#4166)
74f9af4 
* fix #4154 should be more version independent

* fix putmapping API test now that [Shape] is no longer attributed on ArbitraryShape
@Mpdreamz Mpdreamz deleted the feature/7.x/shape-mapping branch November 6, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
backport main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebrain @Mpdreamz