Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add important admonition about using System.Decimal POCO property types #2495

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Add important admonition about using System.Decimal POCO property types #2495

merged 1 commit into from
Dec 16, 2016

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Dec 14, 2016

Bump AsciiDoctNet to support additional asciidoc syntax
Closes #2463

@russcam
Add important admonition about using System.Decimal POCO property types
5c5df6d 
Bump AsciiDoctNet to support additional asciidoc syntax
Closes #2463
Mpdreamz
Mpdreamz approved these changes Dec 16, 2016
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome comments

@Mpdreamz Mpdreamz merged commit d7eb6e1 into 2.x Dec 16, 2016
@Mpdreamz Mpdreamz deleted the enhancement/2.x-handling-decimals branch December 16, 2016 13:15
Mpdreamz pushed a commit that referenced this pull request Dec 16, 2016
@russcam @Mpdreamz
Add important admonition about using System.Decimal POCO property typ…
54fc967 
…es (#2495)

Bump AsciiDoctNet to support additional asciidoc syntax
Closes #2463
Conflicts:
	src/Tests/ClientConcepts/HighLevel/Mapping/AutoMap.doc.cs
Mpdreamz pushed a commit that referenced this pull request Dec 16, 2016
@russcam @Mpdreamz
Add important admonition about using System.Decimal POCO property typ…
41f3caa 
…es (#2495)

Bump AsciiDoctNet to support additional asciidoc syntax
Closes #2463
Conflicts:
	src/Tests/ClientConcepts/HighLevel/Mapping/AutoMap.doc.cs
@Mpdreamz
Copy link
Member

ported to master and 5.x

awelburn pushed a commit to Artesian/elasticsearch-net that referenced this pull request Nov 6, 2017
@russcam
Add important admonition about using System.Decimal POCO property typ…
6e39dde 
…es (elastic#2495)

Bump AsciiDoctNet to support additional asciidoc syntax
Closes elastic#2463
Conflicts:
	src/Tests/ClientConcepts/HighLevel/Mapping/AutoMap.doc.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
backport main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russcam @Mpdreamz