Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEST - SearchRequest ignores default index #907

Closed
Roemer opened this issue Aug 26, 2014 · 2 comments
Closed

NEST - SearchRequest ignores default index #907

Roemer opened this issue Aug 26, 2014 · 2 comments
Assignees
@Mpdreamz

Comments

@Roemer
Copy link

Roemer commented Aug 26, 2014

When using a SearchRequest object without specifying an Index, the DefaultIndex defined in the ElasticClient is ignored and all indexes are being searched. But when using a SearchDescriptor without specifying an index, the DefaultIndex is used correctly.
@Mpdreamz Mpdreamz self-assigned this Aug 26, 2014
@Mpdreamz
Copy link
Member

@Roemer many kudos for catching this one.

SearchDescriptor() should default to /default-index/_search unless AllIndices / AllTypes / Indices / Types are explicitly stated.

SearchDescriptor<T> should default to /default-index-for-t/default-type-for-t/_search unless AllIndices / AllTypes / Indices / Types are explicitly stated.

I just pushed a fix for this 👍 for reporting.

@Roemer
Copy link
Author

Roemer commented Aug 26, 2014

Awesome fast handling, thanks!

gmarz added a commit that referenced this issue Aug 26, 2014
@gmarz
Fix MultiSearchRequest test to account for #907
e768a06
Tasteful pushed a commit to Tasteful/elasticsearch-net that referenced this issue Aug 27, 2014
@Mpdreamz @Tasteful
fix elastic#907 using untyped SearchRequest() should still infer defa…
536680d 
…ult index
Tasteful pushed a commit to Tasteful/elasticsearch-net that referenced this issue Aug 27, 2014
@gmarz @Tasteful
Fix MultiSearchRequest test to account for elastic#907
2840c3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mpdreamz Mpdreamz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mpdreamz @Roemer