Terms not working as expected

[nascosto]

I didn't have this problem with pre-1.0.0. I'm attempting to use 1.0.1 right now

I'm having a problem with Terms. It only seems to work for strings. In my case, longs and enums are leaving the filter empty. Also, before I could pass in null to Terms and it would handle it correctly. I can no longer do that. It throws a System.AggregateException in mscorlib.

var query = Query<MyType>.Filtered(filtered => filtered
    .Filter(f =>
        f.Terms(t => t.longValue, new long[] { 1, 2, 3 }) // Produces empty filter
    )
    .Query(q => q.MatchAll())
);

var query = Query<MyType>.Filtered(filtered => filtered
    .Filter(f =>
        f.Terms(t => t.stringValue, new string[] { "test1", "test2", "test3" }) // Working
    )
    .Query(q => q.MatchAll())
);

var query = Query<MyType>.Filtered(filtered => filtered
    .Filter(f =>
        f.Terms(t => t.longValue, new long[] { 1, 2, 3}) && // Produces filter with just the string term filter
        f.Terms(t => t.stringValue, new string[] { "test1", "test2", "test3" }) 
    )
    .Query(q => q.MatchAll())
);

var query = Query<MyType>.Filtered(filtered => filtered
    .Filter(f =>
        f.Terms(t => t.stringValue, (string[]) null) // Boom - Exception thrown
    )
    .Query(q => q.MatchAll())
);

Am I doing something wrong or is this a bug?

[gmarz]

@nascosto Yea, this definitely looks like a bug. Good catch and thanks for reporting. I'm looking into it now.

[nascosto]

Thanks for fixing this. Looking forward to its release.

[gmarz]

@nascosto no problem. If you don't want to wait for the 1.0.2 stable release, you can always grab the NuGet package from our CI builds at https://www.myget.org/gallery/elasticsearch-net.