-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low level client exception structure should match SimpleJson #3656
Comments
we created a custom strategy for exceptions for SimpleJson: So we need to match that one not This strategy closely mimics what https://github.com/serilog/serilog-sinks-elasticsearch does when I submitted this PR for its 2.0 serilog-contrib/serilog-sinks-elasticsearch#1 We should definitely learn from what has happened on that repos since, lotsa great options and different outputs for different usecases. Even different usecases within just Kibana. I would love long term for us to maintain a dependency free For the initial cc @mivano |
This commit introduces an ExceptionFormatters that serializes exceptions to the same structure as that used in 6.x Fixes #3656
Closing this as #3662 has been merged into 7.x |
With the move to utf8json in #3493, we should ensure that the serialized structured of an exception in the low level client matches that of SimpleJson, the preceding low level client serializer.
This may also be an opportunity to create a better exception structure, to support indexing into Elasticsearch and other logging systems.
The text was updated successfully, but these errors were encountered: