Allow JacksonJsonpMapper user provided ObjectMapper to maintain configuration #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
mluckam
force-pushed
the
jackson_mapper_constructor
branch
from
c6c8a90 to
64bd09f
Compare
|
@elasticmachine ok to test |
swallez
reviewed
Oct 31, 2022
java-client/src/main/java/co/elastic/clients/json/jackson/JacksonJsonpMapper.java
Outdated
Show resolved
Hide resolved
mluckam
force-pushed
the
jackson_mapper_constructor
branch
2 times, most recently
from
4cdf128 to
ea429bf
Compare
swallez
approved these changes
Oct 31, 2022
swallez
pushed a commit
that referenced
this pull request
Oct 31, 2022
swallez
pushed a commit
that referenced
this pull request
Oct 31, 2022
4 tasks
|
It is great to have that implemented. Thanks for that. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JacksonJsonpMapper has a public constructor that takes in a user provided ObjectMapper to allow customization for serialization and deserialization. The constructor can be misleading since it overrides two configurations to disable pretty print and disregard null values on serialization. As far as I can tell, there is no other way to modify the ObjectMapper configuration other than through the constructor.
The proposal is that these configurations be moved to the default constructor. This allows users with no preference to take the default configuration, but if custom configuration is desired a user can provide the ObjectMapper. A few advantages to this strategy:
For context, the change was made in this commit.