Prevent Float value from automatically becoming BigDecimal when using Oj #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyoshidajp
commented
Sep 18, 2023
|
|
||
| # Prevent Float value from automatically becoming BigDecimal when using Oj | ||
| options = {} | ||
| options[:mode] = :compat if serializer.is_a?(Serializer::MultiJson) && defined?(::Oj) |
There was a problem hiding this comment.
This may be a technical debt, but I couldn't figure out a better way.
|
Thank you very much for this fix @kyoshidajp. Could you add a test for the bug please? Something like the code you added to the very detailed issue you reported would be very useful. Thanks! |
|
@picandocodigo Thanks. I added a test. |
picandocodigo
force-pushed
the
add_compat_mode_for_oj
branch
from
b5dd7a7 to
cd6e15c
Compare
|
Thank you very much @kyoshidajp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67
Only
compatmode cat prevent automatically becoming BigDecimal when using oj.