Use Terraform Dependecy Lock in system tests #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
Feb 14, 2022
| cp -r /stage/* /workspace | ||
| # Hidden files are not copied over, we make an exception for Terraform Dependency Lock file. | ||
| # See more: https://github.com/elastic/package-spec/issues/269 | ||
| cp -r /stage/* /stage/.terraform.lock.hcl /workspace |
There was a problem hiding this comment.
Let's make it future-proof, in case we need to add more hidden files: cp -a /stage/ /workspace/. Could you please check if it works correctly?
There was a problem hiding this comment.
cp -a /stage/ /workspace/ does not copy all files, but the entire folder.
cp -a /stage/. /workspace/ does copy all visible and hidden files. Commit updated.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Terraform Lock File support has been added elastic/package-spec#269 but was not used by Terraform Deployer as the file was not copied from the stage folder to the workspace. cp * does not copy hidden files. This commit adds copy for hidden files from the stage to the workspace folder, so it's correctly picked up by Terraform in tests.
mtojek
approved these changes
Feb 14, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform Lock File support has been added elastic/package-spec#269
but was not used by Terraform Deployer as the file was not copied from
the stage folder to the workspace.
cp *does not copy hidden files.This commit adds copy for .terraform.lock.hcl from the stage to the
workspace folder, so it's correctly picked up by Terraform in tests.