Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset tests] Add installationInfo field to API response of get package #2233

Merged

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Nov 19, 2024

Asset tests are failing due to savedObject field is missing from the API response GET /api/fleet/epm/packages/<package>/<version>.

Probably related to this https://github.com/elastic/kibana/pull/198434/files#diff-466e258cb2e72645d2355d6d3bdb742b38059e03eb1830ee04afb79234520d1bR673

The same data that was present in savedObject is available in the installationInfo field from that API response. This PR updates the response in order to get the Kibana and Elasticsearch assets from the installationInfo field.

Example of builds where it is failing:
https://buildkite.com/elastic/elastic-package-test-serverless/builds/210
https://buildkite.com/elastic/integrations/builds/18433

Author's Checklist

How to test this

elastic-package stack down -v
elastic-package stack update -v --version 9.0.0-SNAPSHOT
elastic-package stack up -v --version 9.0.0-SNAPSHOT

cd test/packages/parallel/apache
elastic-package test -v

# test other packages if required

elastic-package stack down -v

@mrodm mrodm self-assigned this Nov 19, 2024
@mrodm
Copy link
Contributor Author

mrodm commented Nov 19, 2024

buildkite test serverless

@elastic-vault-github-plugin-prod

@elasticmachine
Copy link
Collaborator

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @mrodm

@mrodm mrodm marked this pull request as ready for review November 19, 2024 11:39
@mrodm mrodm requested a review from a team November 19, 2024 11:39
@mrodm mrodm merged commit c5cbbab into elastic:main Nov 19, 2024
3 checks passed
@mrodm mrodm deleted the add-installation-info-field-get-package-response branch November 19, 2024 11:51
@mrodm mrodm mentioned this pull request Nov 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants