Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set latency preset in the default ES output #1996

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jul 30, 2024

Fixes #1956

Set for Elastic Stack versions >=8.12 the Elasticsearch output preset latency as the default value.

For Elastic Stack versions >=8.0 & < 8.12, those settings that latency preset configures are added directly to the output via config key.

An example of applying this change running system tests with nginx package (from elastic-package repo):

  • latency preset set:
╭─────────┬─────────────┬───────────┬───────────────────────┬────────┬───────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME             │ RESULT │  TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────────────────┼────────┼───────────────┤
│ nginx   │ access      │ system    │ default (variant: v1) │ PASS   │   31.4586152s │
│ nginx   │ error       │ system    │ default (variant: v1) │ PASS   │ 31.071471239s │
│ nginx   │ stubstatus  │ system    │ default (variant: v1) │ PASS   │ 32.145618723s │
╰─────────┴─────────────┴───────────┴───────────────────────┴────────┴───────────────╯
  • default preset (balanced):
╭─────────┬─────────────┬───────────┬───────────────────────┬────────┬───────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME             │ RESULT │  TIME ELAPSED │
├─────────┼─────────────┼───────────┼───────────────────────┼────────┼───────────────┤
│ nginx   │ access      │ system    │ default (variant: v1) │ PASS   │ 43.745287116s │
│ nginx   │ error       │ system    │ default (variant: v1) │ PASS   │ 42.650101001s │
│ nginx   │ stubstatus  │ system    │ default (variant: v1) │ PASS   │  40.52918326s │
╰─────────┴─────────────┴───────────┴───────────────────────┴────────┴───────────────╯

@mrodm mrodm self-assigned this Jul 30, 2024
@mrodm
Copy link
Contributor Author

mrodm commented Jul 30, 2024

test integrations

@elastic-vault-github-plugin-prod

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10655

@@ -125,6 +125,20 @@ xpack.fleet.outputs:
ca_trusted_fingerprint: "${ELASTIC_PACKAGE_CA_TRUSTED_FINGERPRINT}"
is_default: true
is_default_monitoring: true
{{- if semverLessThan $version "8.12.0" }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added support for preset field in Kibana here (Kibana >=8.12)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 31, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @mrodm

@mrodm
Copy link
Contributor Author

mrodm commented Jul 31, 2024

test integrations

@elastic-vault-github-plugin-prod

Created or updated PR in integrations repository to test this version. Check elastic/integrations#10655

@mrodm mrodm marked this pull request as ready for review July 31, 2024 10:39
@mrodm mrodm merged commit 64d55ef into elastic:main Jul 31, 2024
3 checks passed
@mrodm mrodm deleted the set_latency_preset branch July 31, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Elastic Agent output mode to latency for system tests
3 participants